From b09b2e85e876d74b6f7037552f9a48c9c478ed36 Mon Sep 17 00:00:00 2001 From: Stivenjs Date: Fri, 6 Jun 2025 23:36:16 -0500 Subject: [PATCH] refactor(template-loader): streamline S3 client initialization with consistent credential handling and region configuration --- app/api/stores/template/route.ts | 11 ++++------- lib/store-renderer/services/template-loader.ts | 13 +++++-------- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/app/api/stores/template/route.ts b/app/api/stores/template/route.ts index 4f6f8880..3aec6dce 100644 --- a/app/api/stores/template/route.ts +++ b/app/api/stores/template/route.ts @@ -25,14 +25,11 @@ interface TemplateFile { // Configuración de S3 const s3Client = new S3Client({ + credentials: { + accessKeyId: process.env.ACCESS_KEY_ID || '', + secretAccessKey: process.env.SECRET_ACCESS_KEY || '', + }, region: process.env.REGION_BUCKET || 'us-east-2', - credentials: - process.env.ACCESS_KEY_ID && process.env.SECRET_ACCESS_KEY - ? { - accessKeyId: process.env.ACCESS_KEY_ID, - secretAccessKey: process.env.SECRET_ACCESS_KEY, - } - : undefined, }) const BUCKET_NAME = process.env.BUCKET_NAME || '' diff --git a/lib/store-renderer/services/template-loader.ts b/lib/store-renderer/services/template-loader.ts index b2e3e127..086fbd67 100644 --- a/lib/store-renderer/services/template-loader.ts +++ b/lib/store-renderer/services/template-loader.ts @@ -25,14 +25,11 @@ class TemplateLoader { // Solo inicializar S3 si tenemos bucket configurado if (this.bucketName) { this.s3Client = new S3Client({ - region: process.env.REGION_BUCKET || 'us-east-2', - credentials: - process.env.ACCESS_KEY_ID && process.env.SECRET_ACCESS_KEY - ? { - accessKeyId: process.env.ACCESS_KEY_ID, - secretAccessKey: process.env.SECRET_ACCESS_KEY, - } - : undefined, + credentials: { + accessKeyId: process.env.ACCESS_KEY_ID || '', + secretAccessKey: process.env.SECRET_ACCESS_KEY || '', + }, + region: process.env.AWS_REGION_BUCKET || 'us-east-2', }) } }