Build crashing on Ubuntu 23.10

[mattanikiej]

The build is crashing for me on Ubuntu Desktop 23.10. I tried following along the other open issue and built with g++12 and clang, but still get issue. The error always comes when trying to build the PyScripting namespace. For reference here is how I'm building:

mkdir build
cd build
cmake ..
make -j $(nproc)

and it fails on the last command before I can install it. Here is the error, it is the same regardless of compiler used:

/home/macio/dolphin/Source/Core/Scripting/Python/PyScriptingBackend.cpp: In constructor ‘PyScripting::PyScriptingBackend::PyScriptingBackend(std::filesystem::__cxx11::path, API::EventHub&, API::Gui&, API::BaseManip&, API::BaseManip&, API::BaseManip&, API::BaseManip&, API::BaseManip&)’:
/home/macio/dolphin/Source/Core/Scripting/Python/PyScriptingBackend.cpp:148:5: error: ‘PyInterpreterConfig’ was not declared in this scope; did you mean ‘PyInterpreterState’?
  148 |     PyInterpreterConfig config = {
      |     ^~~~~~~~~~~~~~~~~~~
      |     PyInterpreterState
/home/macio/dolphin/Source/Core/Scripting/Python/PyScriptingBackend.cpp:153:75: error: ‘config’ was not declared in this scope; did you mean ‘Config’?
  153 |     PyStatus status = Py_NewInterpreterFromConfig(&m_interp_threadstate, &config);
      |                                                                           ^~~~~~
      |                                                                           Config
/home/macio/dolphin/Source/Core/Scripting/Python/PyScriptingBackend.cpp:153:23: error: ‘Py_NewInterpreterFromConfig’ was not declared in this scope
  153 |     PyStatus status = Py_NewInterpreterFromConfig(&m_interp_threadstate, &config);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/macio/dolphin/Source/Core/Scripting/Python/PyScriptingBackend.cpp:170:59: error: ‘PyErr_GetRaisedException’ was not declared in this scope; did you mean ‘PyErr_GetHandledException’?
  170 |       const char* ex_cstr = PyUnicode_AsUTF8(PyObject_Str(PyErr_GetRaisedException()));
      |                                                           ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                                           PyErr_GetHandledException
/home/macio/dolphin/Source/Core/Scripting/Python/PyScriptingBackend.cpp:178:59: error: ‘PyErr_GetRaisedException’ was not declared in this scope; did you mean ‘PyErr_GetHandledException’?
  178 |       const char* ex_cstr = PyUnicode_AsUTF8(PyObject_Str(PyErr_GetRaisedException()));
      |                                                           ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                                           PyErr_GetHandledException
make[2]: *** [Source/Core/Scripting/CMakeFiles/scripting.dir/build.make:90: Source/Core/Scripting/CMakeFiles/scripting.dir/Python/PyScriptingBackend.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:2060: Source/Core/Scripting/CMakeFiles/scripting.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

Is it an issue with my python? for context I have miniconda installed. Any help would be greatly appreciated.

[Felk]

Hey, I'm not sure if it's a problem with the code or python somehow. I only really test on windows, so it's definetely possible I just messed something up. I'll try to take a look soon-ish. Thanks for reporting!

[AdarshKSharma]

I am getting same error on MacOS too

[AdarshKSharma]

[ 65%] Building CXX object Source/Core/Scripting/CMakeFiles/scripting.dir/Python/PyScriptingBackend.cpp.o
/Users/adarsh/Downloads/dolphin/dolphin/Source/Core/Scripting/Python/PyScriptingBackend.cpp:148:5: error: unknown type name 'PyInterpreterConfig'; did you mean 'PyInterpreterState'?
PyInterpreterConfig config = {
^~~~~~~~~~~~~~~~~~~
PyInterpreterState
/opt/homebrew/opt/python@3.11/Frameworks/Python.framework/Versions/3.11/include/python3.11/pytypedefs.h:25:20: note: 'PyInterpreterState' declared here
typedef struct _is PyInterpreterState;

[AdarshKSharma]

Able to fix the issue by installing Python3.12

New in version 3.12.
Sub-interpreters are most effective when isolated from each other, with certain functionality restricted:

PyInterpreterConfig config = {
.use_main_obmalloc = 0,
.allow_fork = 0,
.allow_exec = 0,
.allow_threads = 1,
.allow_daemon_threads = 0,
.check_multi_interp_extensions = 1,
.gil = PyInterpreterConfig_OWN_GIL,
};
PyThreadState *tstate = Py_NewInterpreterFromConfig(&config);