Frame advance bug that prevent hotkeys from working

[Blounard]

When a game is emulated, if you :
-pause the emulation (tested with the pause hotkey, while having focus on the emulation render window)
-lose focus on the emulation render window (for example by clicking on the Main Dolphin window, or just alt tab),
-click back on the emulation render window
-frame advance twice with the frame advance hotkey

You will be in a state where seemingly no hotkey no longer works. This include hotkeys from keyboard, but also hotkeys from controller.
To unpause the game, clicking on the "Play" button on the Main Dolphin window works.

This bug does not happen if you have the option Configuration -> Interface -> Hotkeys Require Window Focus disabled.

I figured this bug also does not happen if you build dolphin without the line API::GetGui().Render(); in OnScreenUI::Finalize in Source/Core/VideoCommon/OnScreenUI.cpp (but it remove the ability for scripts to display text on screen as far as i know)

Edit : It seems that the bug does not happen if when you click back on the emulation render window, you click on the window title bar. It also seems fine when you simply alt tab back to the emulation render window. It start breaking when you click inside the emulation render window itself.

[Blounard]

Found a way to fix it : Blounard@e3c68d4

[Felk]

Thanks for investigating this issue! That seems very specific, and I don't really understand how the suggested fix fixes things, but I'll gladly integrate it with the respective explanation.
Do you mind me cherry picking your changes? Or would you be willing to open a pull request?

[Blounard]

Feel free to cherry pick, i'm not sure how to make a PR from a different fork.
Also feel free to try to understand why it works, and/or if it was the correct approach to the bug, I don't know much about C++ myself, I was very lucky to find a way to fix it.

[Tales-Carvalho]

Just wanted to +1 this as I got the same behaviour when trying this branch, and the commit did fix it for me too.