Skip to content

Update to properly work and highlight#6

Merged
FichteFoll merged 3 commits into
FichteFoll:masterfrom
camila314:master
Jun 12, 2025
Merged

Update to properly work and highlight#6
FichteFoll merged 3 commits into
FichteFoll:masterfrom
camila314:master

Conversation

@camila314
Copy link
Copy Markdown
Contributor

Didn't work for me originally but these changes fixed for me

@jrappen
Copy link
Copy Markdown

jrappen commented Mar 7, 2025

Could you also fix to require basename.startswith("syntax_test_") (with trailing _) while at it for file name a few lines down?

@FichteFoll
Copy link
Copy Markdown
Owner

Thanks for the changes. We will have to either make this change conditional based on which ST build we're running on, or I will have to make a new release channel for ST builds above the first version that changed the output format. Since this package hasn't needed updates in the past 6 years, I currently prefer the latter.

I will take a closer look and pepare a new release when I find the time.

@kaste
Copy link
Copy Markdown
Contributor

kaste commented Mar 7, 2025

I've prepared a PR at SL's package control to freeze a ST3 version. You just need to make and push a tag st3-1.1.2 pointing to the current v1.1.2. After that I could merge, the PR; if I merge before the tag, PC marks this plugin as invalid or missing IIRC.

Finally, you could then add a .python-version file here to lift the plugin to Python 3.8, and use the walrus ( elif car := carats.search(m.message):) here in this PR.

Copy link
Copy Markdown
Owner

@FichteFoll FichteFoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, even though it took a while for me to take a proper look at it, but I knew I didn't want to merge it as-is, so I had to set some time aside.

@FichteFoll FichteFoll merged commit bf5ec43 into FichteFoll:master Jun 12, 2025
@FichteFoll FichteFoll added this to the 2.0.0 milestone Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants