From 9b7328176251bcde3035f0082a7720b4b3cc9c4f Mon Sep 17 00:00:00 2001 From: ft-upp-team Date: Thu, 15 Dec 2022 15:07:58 +0000 Subject: [PATCH] Updating Pull Request Template. --- .github/pull_request_template.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8518db2..c8adf1c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -25,5 +25,16 @@ _Is there a better library for doing x_ - [ ] Breaking change - [ ] Minor change (e.g. fixing a typo, adding config) +## DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review" + +- [ ] Test coverage is not significantly decreased +- [ ] All PR checks have passed +- [ ] Changes are deployed on dev before asking for review +- [ ] Documentations remains up-to-date + - [ ] OpenAPI definition file is updated + - [ ] README file is updated + - [ ] Documentation is updated in upp-docs and upp-public-docs + - [ ] Architecture diagrams are updated + ___ This Pull Request follows the rules described in our [Pull Requests Guide](https://github.com/Financial-Times/upp-docs/tree/master/guides/pr-guide)