From 758ce422c230b71153681e77cb208282d51c8a22 Mon Sep 17 00:00:00 2001 From: Nils Lehnen <30603423+iderex@users.noreply.github.com> Date: Fri, 18 Sep 2026 12:16:11 +0200 Subject: [PATCH] Say what counts as watched in the federation register, not which issue will decide it (#489) The `WhatWasPlayed` item of `SharedItem` in `src/server/federation.rs` described part of what a federation act may share as "whatever #60 decides counts as watched". #60 decided it: it closed as completed on 2026-08-27, nine hours after this sentence landed, and `src/playback/watched.rs` arrived two hours after that applying the rule, which is 0060's and takes 0058's boundary rather than stating a second number. The item now says that and names the module. What that prevents is a person being unable to read what they are consenting to. `SharedItem` is the closed set a federation act enumerates, and this module's own header says the enumeration is what the core is bound by afterwards, so it is the register somebody opens to find out exactly what leaves the device when an act is performed. One member of it answered with an open question, and the natural reading of a closed issue is that the answer exists somewhere the file does not name. Everything else in the item is kept. 0068 still places it closest to the sensitive kind, its reason is unchanged, and what was played, when and how far it got are untouched. No member is added to or removed from the set. The sentence went stale within hours of landing rather than landing refuted, because the change that decided the rule had no reason to open the federation register, and the correction at the site says so in those words. It was found by reading every issue number this tree names outside `docs/decisions/` against the state of that issue on the tracker. Nothing else moves. No behaviour, signature, variant or refusal. Closes #489 Signed-off-by: Nils Lehnen <30603423+iderex@users.noreply.github.com> --- src/server/federation.rs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/server/federation.rs b/src/server/federation.rs index fed282f..448ddcf 100644 --- a/src/server/federation.rs +++ b/src/server/federation.rs @@ -104,9 +104,16 @@ pub enum SharedItem { /// Titles, identifiers, artwork and any metadata that came back about what /// is on that server. WhatIsInTheLibrary, - /// What was played, when, how far it got, and whatever #60 decides counts as - /// watched. 0068 places this closest to the sensitive kind, because a - /// viewing history says a great deal about a person. + /// What was played, when, how far it got, and what counts as watched, which + /// is 0060's rule and is applied in [`crate::playback::watched`]. 0068 places + /// this closest to the sensitive kind, because a viewing history says a great + /// deal about a person. + /// + /// THIS ITEM SAID "whatever #60 decides counts as watched". That issue + /// decided it and closed as completed on 2026-08-27, nine hours after this + /// sentence landed, and the module applying the rule arrived two hours after + /// that. So the sentence went stale rather than landing refuted, which is the + /// milder of the two states. #489 is where it was found. WhatWasPlayed, /// The queue of actions taken while the server was gone, from #47, which is /// the same data with a delay on it.