diff --git a/Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs b/Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs index ea5bd2e..fe19d21 100644 --- a/Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs +++ b/Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs @@ -143,10 +143,14 @@ public void RegisterServices(IServiceCollection serviceCollection, IServerApplic // PairingStateMachine takes this and an IUserMappingStore and the second had no // implementation in this assembly. It has one now and both are registered below. // - // What is unchanged is that nothing on a server writes a record, because nothing joins an - // enrolment to the state machine, which is issue #350. So the read above answers an empty - // list on every server, which is stated at the action rather than left for a reader to - // infer. + // THIS COMMENT SAID NOTHING ON A SERVER WRITES A RECORD AND THAT THE READ ABOVE ANSWERS + // AN EMPTY LIST ON EVERY SERVER, because nothing joined an enrolment to the state + // machine. Enrolment.Open applies LocalEvent.WindowOpened through the state machine and + // the administrative plane calls it, so a window an administrator opens is a record in + // PairingState.Offered and the read answers with it. + // + // What is unchanged is that no record reaches PairingState.Active, because the ceremony + // that would take it there is issue #19 and nothing derives a long term key pair yet. serviceCollection.AddSingleton(services => new FilePairingRecordStore( RecordStorePath.FileFor(services.GetRequiredService()))); diff --git a/docs/logging.md b/docs/logging.md index 9af9694..a4d7dd6 100644 --- a/docs/logging.md +++ b/docs/logging.md @@ -236,8 +236,8 @@ writes is under the reading rather than counted here. origin/master:Jellyfin.Plugin.ServerPairing/Mapping/UserMappings.cs:38: private readonly ILogger _log; origin/master:Jellyfin.Plugin.ServerPairing/Mapping/UserMappings.cs:54: public UserMappings(IUserMappingStore mappings, PairingStateMachine pairings, ILogger log) origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:130: services.GetRequiredService>())); - origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:220: services.GetRequiredService>())); - origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:239: services.GetRequiredService>())); + origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:224: services.GetRequiredService>())); + origin/master:Jellyfin.Plugin.ServerPairing/PluginServiceRegistrator.cs:243: services.GetRequiredService>())); THIS BLOCK WENT STALE TWICE AND NO RUN ON THIS REPOSITORY SAW EITHER TIME. It pasted two types, then four, then five, and the command returns 7 that hold a logger; the registration line