Return DNS name on a service

[avalls-smd]

Hi, as far as I can tell the dns_name attribute from the IP of a service is not getting fetched to a corresponding label or the target. Is this intended behaviour?

"targets": [
            "node"
],
"labels": {
            "__meta_netbox_id": "3",
            "__meta_netbox_name": "node",
            "__meta_netbox_display": "node (TCP/9100)",
            "__meta_netbox_ports": "9100",
            "__meta_netbox_tags": "exporter",
            "__meta_netbox_tag_slugs": "exporter",
            "__meta_netbox_parent": "someserver",
            "__meta_netbox_primary_ip": "X.X.X.X",
            "__meta_netbox_primary_ip4": "X.X.X.X",
            "__meta_netbox_site": "Something",
            "__meta_netbox_site_slug": "something"

It would be quite helpful to use the DNS name instead of the primary ip directly.

[koalajoe23]

I added the DNS name to all API endpoints where an IP is returned, see my branch service_dns. Feel free to use or make a PR out of it.

I am no big fan of using DNS names in monitoring unless necessary as it introduces another point of failure. I don't want it to go completely down in case of internal DNS outage/problems. But that may be totally fine in your use case so ymmv.

That said I'm also no big fan of netbox-sd exposing the primary_ip on services. I opened PR #224 as I think services should have a single label for IP listening address(es), be it explicitly configured or primary_ipv4/ipv6 as fallback in case of the service having no ip set.