Foundry V13 - various Marco fixes inside

[warwon]

Not sure how to send this in but anyways,

V13 code for the hex marco

//Generate Hex - Corrected for Foundry V13

const version = '1.0';
// NOTE: Change 'Tables' below to the exact title of your Compendium pack.
const compendium_label = 'Tables';

(async () => {

let hexTypeList = ['Random', 'Countryside', 'Forest', 'River', 'Human Town'];
let selectList = "";

hexTypeList.forEach(option => selectList += "<option value='" + option + "'>" + option + "</option>")

let d = new Dialog({
    title: "Select Type",
    content: "<h2> Select or Roll Hex Type </h2> <select style='margin-bottom:10px;'name='stat' id='stat'> " + selectList + "</select> <br/>",
    buttons: {
        roll: {
            icon: '<i class="fas fa-check"></i>',
            label: "Roll",
            callback: (html) => hexType(html.find('[id=\"stat\"]')[0].value)
        },
        cancel: {
            icon: '<i class="fas fa-times"></i>',
            label: "Cancel",
            callback: () => { }
        }
    },
    default: "roll",
    close: () => { }
});
d.render(true);

})()

async function hexType(hexType) {
let hexContents = "";
let hexDetails = "";
let table = null;
let roll = null;
let randomHex = ['Countryside', 'Forest', 'River', 'Human Town'];

if(hexType == "Random"){
    hexType = randomHex[Math.floor(Math.random() * randomHex.length)];
}

// --- First Table Roll ---
table = await drawFromTable("Hex - " + hexType);
if (!table) return; // Exit if table not found

roll = await table.roll(); // Roll the table (no await on roll() needed typically, but keeping it async-safe)
hexContents = roll.results[0].text; // CORRECTED: Access text directly

// --- Second Table Roll ---
table = await drawFromTable("Hex - Landmark Details");
if (!table) return; // Exit if table not found

roll = await table.roll();
hexDetails = roll.results[0].text; // CORRECTED: Access text directly

let message = "\
<h2> " + hexType + ": </h2>\
<b> Landmark: </b>" + hexContents + "</br>\
<b> Details: </b><i>" + hexDetails + "</i></br>";

let chatData = {
    content: message,
    whisper : ChatMessage.getWhisperRecipients("GM")
};  

ChatMessage.create(chatData);

}

/* Functions */
async function drawFromTable(tableName) {
// CORRECTED: Find the compendium pack by name (label) and document type
const pack = game.packs.filter(p => p.documentName === 'RollTable').find(p => p.metadata.label === compendium_label);

if (!pack) {
    ui.notifications.warn(`Compendium pack with label ${compendium_label} not found.`, {});
    return;
}

// CORRECTED: Use getDocuments() to get the content and filter by name
const inside = await pack.getDocuments(); 
const table = inside.find(p => p.name === tableName);

if (!table) {
    ui.notifications.warn(`Table ${tableName} not found in pack ${compendium_label}.`, {});
    return;
}
return table;

}

[warwon]

//Generate Weather - Corrected for Foundry V13

const version = '1.2';
// NOTE: Change 'Tables' below to the exact title of your Compendium pack containing the Mausritter tables.
const compendium_label = 'Tables';

(async () => {

let seasonList = ['Summer', 'Autumn', 'Winter', 'Spring'];
let selectList = "";

seasonList.forEach(option => selectList += "<option value='" + option + "'>" + option + "</option>")

let d = new Dialog({
    title: "Select Season",
    content: "<h2> Season </h2> <select style='margin-bottom:10px;'name='stat' id='stat'> " + selectList + "</select> <br/>",
    buttons: {
        roll: {
            icon: '<i class="fas fa-check"></i>',
            label: "Roll",
            // The callback now calls the updated drawFromTable with the full name 'Weather SeasonName'
            callback: (html) => drawFromTable('Weather ' + html.find('[id=\"stat\"]')[0].value)
        },
        cancel: {
            icon: '<i class="fas fa-times"></i>',
            label: "Cancel",
            callback: () => { }
        }
    },
    default: "roll",
    close: () => { }
});
d.render(true);

})()

/* Functions - ALL UPDATED FOR V13 */
async function drawFromTable(tableName) {
// CORRECTED: Find the compendium pack by name (label) and document type 'RollTable'
const pack = game.packs.filter(p => p.documentName === 'RollTable').find(p => p.metadata.label === compendium_label);

if (!pack) {
    ui.notifications.warn(`Compendium pack with label ${compendium_label} not found.`, {});
    return;
}

// CORRECTED: Get documents from the pack and find the table by name
const inside = await pack.getDocuments(); 
const table = inside.find(p => p.name === tableName);

if (!table) {
    ui.notifications.warn(`Table ${tableName} not found.`, {});
    return;
}

// Roll the table
const roll = await table.roll(); 

// CORRECTED: Access the text directly from the result object
const weatherText = roll.results[0].text;  

let message = `
<h2> Today's Weather: </h2>
<b style='font-size:120%;'>${weatherText}</b>
`;

let chatData = {
    content: message,
    whisper : ChatMessage.getWhisperRecipients("GM")
};  

ChatMessage.create(chatData);  

}

[warwon]

Added weather also

[warwon]

/* Instant NPC - v1.8 - FINAL DEBUG FIX: Hardened Table Access & Stat Injection */

// --- CONFIGURATION ---
const compendium_label = 'Tables'; // Change to your actual Compendium label if different

// --- Hardened drawFromTable ---
async function drawFromTable(tableName) {
const pack = game.packs.get("mausritter.tables");
if (!pack) {
ui.notifications.error(FATAL ERROR: Compendium pack 'mausritter.tables' not found.);
return null;
}

const documents = await pack.getDocuments();
const table = documents.find(p => p.name === tableName);
if (!table) {
    ui.notifications.warn(`Table '${tableName}' not found.`);
    return null;
}

const roll = await table.roll();
if (roll.results?.[0]?.text) {
    return roll.results[0].text;
} else {
    ui.notifications.warn(`Table '${tableName}' rolled with no text result.`);
    return null;
}

}

// --- Async-safe dice rolls ---
async function attrRoll() {
return (await new Roll('2d6').evaluate()).total;
}
async function healthRoll() {
return (await new Roll('1d6').evaluate()).total;
}

// --- Main Execution ---
(async () => {
// --- Table draws ---
const Appearance = await drawFromTable('Non-player mice - Appearance') || 'N/A';
const Birthsign = await drawFromTable('Non-player mice - Birthsign and Disposition') || 'N/A';
const Quirk = await drawFromTable('Non-player mice - Quirk') || 'N/A';
const Social = await drawFromTable('Non-player mice - Social position and Payment for service') || 'N/A';
const Wants = await drawFromTable('Non-player mice - Wants') || 'N/A';
const Relationship = await drawFromTable('Non-player mice - Relationship') || 'N/A';
const Birthname = await drawFromTable('Mousy Names - Birthname') || 'Unnamed Mouse';
const Matriname = await drawFromTable('Mousy Names - Matriname') || '';

if (Birthname === 'Unnamed Mouse') {
    ui.notifications.error("NPC creation failed due to missing Name tables.");
    return;
}

// --- Stat rolls ---
const dexterity = await attrRoll();
const strength = await attrRoll();
const will = await attrRoll();
const health = await healthRoll();

// --- Description block ---
const notes = `
    <h3>NPC Details</h3>
    <p><b>Birthsign & Disposition:</b> ${Birthsign}</p>
    <p><b>Social position and Payment:</b> ${Social}</p>
    <p><b>Appearance:</b> ${Appearance}</p>
    <p><b>Quirk:</b> ${Quirk}</p>
    <p><b>Wants:</b> ${Wants}</p>
    <p><b>Relationship:</b> ${Relationship}</p>
`;

// --- Initial Actor creation ---
const initialData = {
    name: `${Birthname} ${Matriname}`,
    type: "hireling", // Change if needed based on your system schema
    system: {
        description: { disposition: Birthsign },
        notes: notes,
        hits: { value: 2, max: 2 },
        health: { value: 0, max: 0, min: 0 },
        stats: {
            strength: { value: 0, max: 0, label: "Strength" },
            dexterity: { value: 0, max: 0, label: "Dexterity" },
            will: { value: 0, max: 0, label: "Will" }
        }
    }
};

let instantNPC;
try {
    instantNPC = await Actor.create(initialData);
} catch (e) {
    ui.notifications.error(`[CRASH] Failed to create Actor: ${e.message}`);
    console.error("Actor Creation Error:", e);
    return;
}

// --- Stat injection ---
const updateData = {
    'system.health.max': health,
    'system.health.value': health,
    'system.health.min': 0,
    'system.stats.strength.value': strength,
    'system.stats.strength.max': strength,
    'system.stats.dexterity.value': dexterity,
    'system.stats.dexterity.max': dexterity,
    'system.stats.will.value': will,
    'system.stats.will.max': will
};

try {
    await instantNPC.update(updateData);
    await instantNPC.sheet.render(true);
} catch (e) {
    ui.notifications.error(`[CRASH] Failed to update Actor stats: ${e.message}`);
    console.error("Actor Update Error:", e);
}

})();

[warwon]

NPC code is fixed