From 42bf7f8b050c1c487ed0c27f0c3256838393f63f Mon Sep 17 00:00:00 2001 From: SoFlo1 Date: Thu, 14 May 2026 09:02:30 -0400 Subject: [PATCH] ci: add decision frontmatter + fix linux-only errcheck on conn.CloseLasting - docs/design/asdd-whitepaper.md: add `decision: gm-v0sp` frontmatter - docs/design/gemba-remote.md: add `decision: gm-o9t8` frontmatter (both flagged by cmd/check-decisions --docs-only) - internal/adapter/firecracker/egress_linux.go: wrap defer conn.CloseLasting() in a func to satisfy errcheck (this file is //go:build linux so the violation only surfaces on the ubuntu CI runner). Co-Authored-By: Claude Opus 4.7 (1M context) --- docs/design/asdd-whitepaper.md | 5 +++++ docs/design/gemba-remote.md | 5 +++++ internal/adapter/firecracker/egress_linux.go | 4 ++-- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/design/asdd-whitepaper.md b/docs/design/asdd-whitepaper.md index dd19090a..6a01ee7f 100644 --- a/docs/design/asdd-whitepaper.md +++ b/docs/design/asdd-whitepaper.md @@ -1,3 +1,8 @@ +--- +title: "Agentic Spec-Driven Development (ASDD)" +decision: gm-v0sp +--- + # Agentic Spec-Driven Development (ASDD) The gemba approach to building software with autonomous and semi-autonomous diff --git a/docs/design/gemba-remote.md b/docs/design/gemba-remote.md index df051b1f..502e402b 100644 --- a/docs/design/gemba-remote.md +++ b/docs/design/gemba-remote.md @@ -1,3 +1,8 @@ +--- +title: "Gemba Remote — design proposal" +decision: gm-o9t8 +--- + # Gemba Remote — design proposal **Status:** draft for review (2026-05-11) diff --git a/internal/adapter/firecracker/egress_linux.go b/internal/adapter/firecracker/egress_linux.go index dcfb5c50..b4dd9f19 100644 --- a/internal/adapter/firecracker/egress_linux.go +++ b/internal/adapter/firecracker/egress_linux.go @@ -41,7 +41,7 @@ func applyEgressRules(ctx context.Context, log *slog.Logger, vmID, tapIf string, if err != nil { return nil, fmt.Errorf("firecracker/egress: open nftables: %w", err) } - defer conn.CloseLasting() + defer func() { _ = conn.CloseLasting() }() // Best-effort cleanup of any stale table from a prior failed boot. if t, _ := findTable(conn, rs.TableName); t != nil { @@ -99,7 +99,7 @@ func teardownEgressRules(log *slog.Logger, tableName string) error { if err != nil { return fmt.Errorf("firecracker/egress: open nftables for teardown: %w", err) } - defer conn.CloseLasting() + defer func() { _ = conn.CloseLasting() }() t, _ := findTable(conn, tableName) if t == nil {