[FEATURE] Add noise options for tactile sensors: hysteresis, dead taxels, probe gain#2813
[FEATURE] Add noise options for tactile sensors: hysteresis, dead taxels, probe gain#2813Milotrince wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6ff7d64a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uniforms = torch.rand((n_envs, shared_metadata.total_n_probes), device=gs.device, dtype=gs.tc_float) | ||
| shared_metadata.dead_taxel_values[envs_idx] = uniforms * (high - low) + low |
There was a problem hiding this comment.
Sample dead-taxel replacement per output channel
The dead-taxel replacement values are sampled with shape (n_envs, total_n_probes) and later broadcast to cache columns via cache_col_probe_idx, so multi-channel taxels (e.g., force/torque xyz) get the same scalar in every channel for a dead probe. This makes dead outputs artificially correlated and does not match the documented per-channel dead-value behavior, so dead KinematicTaxel/ProximityTaxel readings lose channel independence after each reset.
Useful? React with 👍 / 👎.
Description
ContactProbewith separate contact_threshold / release_thresholdContactDepthProbe,KinematicTaxel,ProximityTaxel,ElastomerTaxelKinematicTaxel, share FFT code withElastomerTaxelRelated Issue
Motivation and Context
How Has This Been / Can This Be Tested?
Added tests to
test_sensors.pyScreenshots (if appropriate):
noisy.mp4
Checklist:
Submitting Code Changessection of CONTRIBUTING document.