Skip to content

[MISC] Add robust nonconvex collision detection for large overlap.#2828

Merged
duburcqa merged 2 commits into
Genesis-Embodied-AI:mainfrom
duburcqa:fix_nonconvex_large_overlap
May 24, 2026
Merged

[MISC] Add robust nonconvex collision detection for large overlap.#2828
duburcqa merged 2 commits into
Genesis-Embodied-AI:mainfrom
duburcqa:fix_nonconvex_large_overlap

Conversation

@duburcqa
Copy link
Copy Markdown
Collaborator

@duburcqa duburcqa commented May 23, 2026

  • Add robust nonconvex collision detection for large overlap.
  • Fix inverted-winding components caused by watertighten dual contouring.

@duburcqa duburcqa requested a review from YilingQiao as a code owner May 23, 2026 22:45
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 520acec145

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread genesis/engine/solvers/rigid/collider/narrowphase.py Outdated
@duburcqa duburcqa force-pushed the fix_nonconvex_large_overlap branch 3 times, most recently from 05a0194 to d8fe0ed Compare May 24, 2026 10:11
@duburcqa duburcqa force-pushed the fix_nonconvex_large_overlap branch from d8fe0ed to f328190 Compare May 24, 2026 13:31
@duburcqa duburcqa merged commit c81777a into Genesis-Embodied-AI:main May 24, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant