Remove obsolete copy step in install script and uninstall.sh in SurfingTile module#299
Open
Astoritin wants to merge 5 commits into
Open
Remove obsolete copy step in install script and uninstall.sh in SurfingTile module#299Astoritin wants to merge 5 commits into
Astoritin wants to merge 5 commits into
Conversation
Astoritin
commented
May 3, 2026
Astoritin
commented
- Remove obsolete Toolbox.sh copy step since Toolbox.sh was removed in commit 4869b33.
- Since Web app has been merged into SurfingTile, it is no longer sound to uninstall the user-space app when removing systemized module as users may want the management panel still without tile feature. That is to say, users need to decide how to handle the user-space SurfingTile app themselves if they uninstall the SurfingTile module only.
MoGuangYu
force-pushed
the
main
branch
2 times, most recently
from
8ac5947 to
bd1166b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.