Add yelouis to cloud debugger Python agent copy.bara.sky file

PiperOrigin-RevId: 259940524
Change-Id: Ic60e4d959e9d46aad6b37bf9464a9f6751657bf1

Author: Louis Ye

src/googleclouddebugger/bytecode_breakpoint.cc

@@ -48,7 +48,7 @@ void BytecodeBreakpoint::Detach() {
     it->second->breakpoints.clear();
     PatchCodeObject(it->second);
 
-    // TODO(vlif): assert zombie_refs.empty() after garbage collection
+    // TODO: assert zombie_refs.empty() after garbage collection
     // for zombie refs is implemented.
 
     delete it->second;

src/googleclouddebugger/bytecode_breakpoint.h

@@ -29,7 +29,7 @@ namespace cdbg {
 // Sets breakpoints in Python code with zero runtime overhead.
 // BytecodeBreakpoint rewrites Python bytecode to insert a breakpoint. The
 // implementation is specific to CPython 2.7.
-// TODO(vlif): rename to BreakpointsEmulator when the original implementation
+// TODO: rename to BreakpointsEmulator when the original implementation
 // of BreakpointsEmulator goes away.
 class BytecodeBreakpoint {
  public:
@@ -94,7 +94,7 @@ class BytecodeBreakpoint {
     // constants. Instead we store these references in a special zombie pool.
     // Then once we know that no Python thread is executing the code object,
     // we can release all of them.
-    // TODO(vlif): implement garbage collection for zombie refs.
+    // TODO: implement garbage collection for zombie refs.
     std::vector<ScopedPyObject> zombie_refs;
 
     // Original value of PyCodeObject::co_stacksize before patching.

src/googleclouddebugger/bytecode_manipulator.cc

@@ -756,7 +756,7 @@ bool BytecodeManipulator::AppendMethodCall(
     // block. Unfortunately not all instructions can be moved:
     // 1. Instructions with relative offset can't be moved forward, because
     //    the offset can't be negative.
-    //    TODO(vlif): FORWARD_JUMP can be replaced with ABSOLUTE_JUMP.
+    //    TODO: FORWARD_JUMP can be replaced with ABSOLUTE_JUMP.
     // 2. YIELD_VALUE can't be moved because generator object keeps the frame
     //    object in between "yield" calls. If the breakpoint is added or
     //    removed, subsequent calls into the generator will jump into invalid

src/googleclouddebugger/capture_collector.py

@@ -14,7 +14,7 @@
 
 """Captures application state on a breakpoint hit."""
 
-# TODO(vlif): rename this file to collector.py.
+# TODO: rename this file to collector.py.
 
 import copy
 import datetime
@@ -53,7 +53,7 @@
 _DATE_TYPES = (datetime.date, datetime.time, datetime.timedelta)
 _VECTOR_TYPES = (tuple, list, set)
 
-# TODO(vlif): move to messages.py module.
+# TODO: move to messages.py module.
 EMPTY_DICTIONARY = 'Empty dictionary'
 EMPTY_COLLECTION = 'Empty collection'
 OBJECT_HAS_NO_FIELDS = 'Object has no fields'
@@ -396,7 +396,7 @@ def CaptureNamedVariable(self, name, value, depth, limits):
     """
     if not hasattr(name, '__dict__'):
       name = str(name)
-    else:  # TODO(vlif): call str(name) with immutability verifier here.
+    else:  # TODO: call str(name) with immutability verifier here.
       name = str(id(name))
     self._total_size += len(name)
 
@@ -488,8 +488,8 @@ def CaptureVariable(self, value, depth, limits, can_enqueue=True):
   def CaptureVariableInternal(self, value, depth, limits, can_enqueue=True):
     """Captures a single nameless object into Variable message.
 
-    TODO(vlif): safely evaluate iterable types.
-    TODO(vlif): safely call str(value)
+    TODO: safely evaluate iterable types.
+    TODO: safely call str(value)
 
     Args:
       value: data to capture
@@ -537,7 +537,7 @@ def CaptureVariableInternal(self, value, depth, limits, can_enqueue=True):
 
     if isinstance(value, types.FunctionType):
       self._total_size += len(value.__name__)
-      # TODO(vlif): set value to func_name and type to 'function'
+      # TODO: set value to func_name and type to 'function'
       return {'value': 'function ' + value.__name__}
 
     if isinstance(value, Exception):
@@ -567,7 +567,7 @@ def CaptureVariableInternal(self, value, depth, limits, can_enqueue=True):
               'type': object_type}
 
     if not hasattr(value, '__dict__'):
-      # TODO(vlif): keep "value" empty and populate the "type" field instead.
+      # TODO: keep "value" empty and populate the "type" field instead.
       r = str(type(value))
       self._total_size += len(r)
       return {'value': r}

src/googleclouddebugger/conditional_breakpoint.cc

@@ -80,7 +80,7 @@ bool ConditionalBreakpoint::EvaluateCondition(PyFrameObject* frame) {
     line_count = immutability_tracer.GetLineCount();
   }
 
-  // TODO(vlif): clear breakpoint if condition evaluation failed due to
+  // TODO: clear breakpoint if condition evaluation failed due to
   // mutable code or timeout.
 
   auto eval_exception = ClearPythonException();

src/googleclouddebugger/immutability_tracer.cc

@@ -414,7 +414,7 @@ static OpcodeMutableStatus IsOpcodeMutable(const uint8 opcode) {
     case IMPORT_FROM:
     case SETUP_EXCEPT:
     case SETUP_FINALLY:
-    // TODO(xinghuadou): allow changing fields of locally created objects/lists.
+    // TODO: allow changing fields of locally created objects/lists.
     case STORE_SUBSCR:
     case DELETE_SUBSCR:
     case STORE_NAME:
@@ -425,11 +425,11 @@ static OpcodeMutableStatus IsOpcodeMutable(const uint8 opcode) {
     case SET_ADD:
     case MAP_ADD:
     case STORE_DEREF:
-    // TODO(xinghuadou): allow exception handling
+    // TODO: allow exception handling
     case RAISE_VARARGS:
     case END_FINALLY:
     case SETUP_WITH:
-    // TODO(xinghuadou): allow closures
+    // TODO: allow closures
     case LOAD_CLOSURE:
 #if PY_MAJOR_VERSION >= 3
     case GET_AITER:
@@ -523,7 +523,7 @@ void ImmutabilityTracer::ProcessCodeRange(const uint8* code_start,
 
 void ImmutabilityTracer::ProcessCCall(PyObject* function) {
   if (PyCFunction_Check(function)) {
-    // TODO(vlif): the application code can define its own "str" function
+    // TODO: the application code can define its own "str" function
     // that will do some evil things. Application can also override builtin
     // "str" method. If we want to protect against it, we should load pointers
     // to native functions when debugger initializes (which happens before
@@ -553,7 +553,7 @@ void ImmutabilityTracer::ProcessCCall(PyObject* function) {
 
 
 void ImmutabilityTracer::SetMutableCodeException() {
-  // TODO(vlif): use custom type for this exception. This way we can provide
+  // TODO: use custom type for this exception. This way we can provide
   // a more detailed error message.
   PyErr_SetString(
       PyExc_SystemError,

src/googleclouddebugger/imphook2.py

@@ -68,7 +68,7 @@ def AddImportCallbackBySuffix(path, callback):
   the callback will be invoked. This function does not validates the existence
   of such a module and it's the responsibility of the caller.
 
-  TODO(erezh): handle module reload.
+  TODO: handle module reload.
 
   Args:
     path: python module file path. It may be missing the directories for the
@@ -418,7 +418,7 @@ def GetModuleFromName(name, path):
     nonempty_modules = (m for m in modules if m)
 
     for module in nonempty_modules:
-      # TODO(emrekultursay): Write unit test to cover None case.
+      # TODO: Write unit test to cover None case.
       mod_file = getattr(module, '__file__', None)
       if not mod_file:
         continue

src/googleclouddebugger/python_breakpoint.py

@@ -26,7 +26,7 @@
 from . import module_search2
 from . import module_utils2
 
-# TODO(vlif): move to messages.py module.
+# TODO: move to messages.py module.
 # Use the following schema to define breakpoint error message constant:
 # ERROR_<Single word from Status.Reference>_<short error name>_<num params>
 ERROR_LOCATION_FILE_EXTENSION_0 = (
@@ -126,7 +126,7 @@ def _MultipleModulesFoundError(path, candidates):
 
 def _NormalizePath(path):
   """Removes surrounding whitespace, leading separator and normalize."""
-  # TODO(emrekultursay): Calling os.path.normpath "may change the meaning of a
+  # TODO: Calling os.path.normpath "may change the meaning of a
   # path that contains symbolic links" (e.g., "A/foo/../B" != "A/B" if foo is a
   # symlink). This might cause trouble when matching against loaded module
   # paths. We should try to avoid using it.
@@ -239,7 +239,7 @@ def GetBreakpointId(self):
 
   def GetExpirationTime(self):
     """Computes the timestamp at which this breakpoint will expire."""
-    # TODO(emrekultursay): Move this to a common method.
+    # TODO: Move this to a common method.
     if '.' not in self.definition['createTime']:
       fmt = '%Y-%m-%dT%H:%M:%S%Z'
     else:
@@ -278,7 +278,7 @@ def _ActivateBreakpoint(self, module):
     if not status:
       # First two parameters are common: the line of the breakpoint and the
       # module we are trying to insert the breakpoint in.
-      # TODO(emrekultursay): Do not display the entire path of the file. Either
+      # TODO: Do not display the entire path of the file. Either
       # strip some prefix, or display the path in the breakpoint.
       params = [str(line), os.path.splitext(module.__file__)[0] + '.py']
 
@@ -398,7 +398,7 @@ def _BreakpointEvent(self, event, frame):
     collector = capture_collector.CaptureCollector(
         self.definition, self.data_visibility_policy)
 
-    # TODO(b/69119299): This is a temporary try/except. All exceptions should be
+    # TODO: This is a temporary try/except. All exceptions should be
     # caught inside Collect and converted into breakpoint error messages.
     try:
       collector.Collect(frame)

src/googleclouddebugger/python_util.cc

@@ -181,7 +181,7 @@ Nullable<string> ClearPythonException() {
     return Nullable<string>();  // return nullptr.
   }
 
-  // TODO(vlif): call str(exception_obj) with a verification of immutability
+  // TODO: call str(exception_obj) with a verification of immutability
   // that the object state is not being altered.
 
   auto exception_type = reinterpret_cast<PyTypeObject*>(exception_obj->ob_type);