Skip to content

Tech debt: IfNull rewrite is in wrong module #1728

@nj1973

Description

@nj1973

I noticed that the lines below in third_party/ibis/ibis_impala/api.py effect more than just Impala:

@rewrites(ops.IfNull)
def _if_null(op):
    return ops.Coalesce((op.arg, op.ifnull_expr))

If I comment out the lines then MySQL generated SQL changes too.

We need to review whether we should move this code to operations.py or remove it and add engine specific rewrites where they are needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions