Skip to content

Add expected decode and extraction results for every XDR fixture #65

Description

@knytcomics-ui

Category

Intermediate

Summary

Create machine-readable expected outcomes for each XDR and verify them against the extension decoder.

Current Behavior

transactions/README.md documents symbolic operations and destinations, while the extension extracts them independently. The current consumer test checks scores only.

Problem

A valid XDR can still decode to the wrong destination, asset, memo, or operation interpretation.

Why This Matters

This validates the core decode-to-score workflow.

Proposed Scope

Add expected destination/asset/memo metadata and a cross-repository test that runs extractDestination.

Acceptance Criteria

  • Every current XDR has machine-readable expected results.
  • Payment, path payment, and change-trust behavior is covered.
  • Decoder mismatches fail with a useful diff.
  • Documentation stays synchronized.

Technical Considerations

Coordinate transactions/, grydlock-extension, and TESTNET passphrase handling.

Testing Requirements

Include the no-destination change-trust case and asset extraction.

Cross-Repository Impact

Directly affects the extension decoder contract.

Out of Scope

Do not add new operation types; issue #37 covers broad XDR parsing.

Complexity

Requires metadata design and cross-repository execution.

Impact

High — validates the product workflow.

Suggested Labels

intermediate, area: testing, area: cross-repo

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions