From 3a611c1f372ce9d165a8488ce758e7f7c3974312 Mon Sep 17 00:00:00 2001 From: HANCORE-linux <230438592+HANCORE-linux@users.noreply.github.com> Date: Mon, 24 Aug 2026 08:09:51 +0200 Subject: [PATCH] fix(control-center): label Now Playing compact mode --- .../WidgetAppearanceWorkbench.qml | 2 +- tests/control-center-regression.sh | 2 +- tests/control-center-smoke.qml | 14 ++++++++++++-- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hancore.shibumi.control-center/WidgetAppearanceWorkbench.qml b/hancore.shibumi.control-center/WidgetAppearanceWorkbench.qml index 045e683..136dc6d 100644 --- a/hancore.shibumi.control-center/WidgetAppearanceWorkbench.qml +++ b/hancore.shibumi.control-center/WidgetAppearanceWorkbench.qml @@ -30,7 +30,7 @@ Column { ] readonly property var mediaStyleOptions: [ { value: "default", label: "Default" }, - { value: "full", label: "Full" } + { value: "full", label: "Compact" } ] readonly property var v1CompactGroupIds: [ "G4", "G5", "G6", "G11", "G12", "G13", "G14", "G15", "G18" diff --git a/tests/control-center-regression.sh b/tests/control-center-regression.sh index 7c45933..107b050 100755 --- a/tests/control-center-regression.sh +++ b/tests/control-center-regression.sh @@ -1764,7 +1764,7 @@ for profile_icon_contract in \ 'WidgetAppearanceWorkbench.qml:{ value: "full", label: "Icon + text" }' \ 'WidgetAppearanceWorkbench.qml:{ value: "text", label: "Text" }' \ 'WidgetAppearanceWorkbench.qml:readonly property var mediaStyleOptions:' \ - 'WidgetAppearanceWorkbench.qml:{ value: "full", label: "Full" }' \ + 'WidgetAppearanceWorkbench.qml:{ value: "full", label: "Compact" }' \ 'WidgetAppearanceWorkbench.qml:readonly property var v1CompactGroupIds:' \ 'WidgetAppearanceWorkbench.qml:if (catalogGroup === "G9") return mediaStyleOptions' \ 'WidgetAppearanceWorkbench.qml:if (controller.v2LayoutActive === true) return displayModeOptions' \ diff --git a/tests/control-center-smoke.qml b/tests/control-center-smoke.qml index b44790b..e12bf42 100644 --- a/tests/control-center-smoke.qml +++ b/tests/control-center-smoke.qml @@ -687,11 +687,16 @@ ShellRoot { appearance.showWidgetOverview() if (!appearance.openWidgetDetails("G9", "") || appearance.selectedWidgetMode !== "default" + || appearance.selectedWidgetModeOptions.length !== 2 + || appearance.selectedWidgetModeOptions[0].value !== "default" + || appearance.selectedWidgetModeOptions[0].label !== "Default" + || appearance.selectedWidgetModeOptions[1].value !== "full" + || appearance.selectedWidgetModeOptions[1].label !== "Compact" || !appearance.cycleSelectedWidgetMode() || appearance.selectedWidgetMode !== "full" || stateService.groupAppearanceSettingForVariant( "G9", "v2", "mediaStyle", "") !== "default") - return root.fail("V1 Now Playing style contract drifted") + return root.fail("V1 Now Playing Default/Compact contract drifted") if (!appearance.cycleSelectedWidgetMode() || appearance.selectedWidgetMode !== "default") return root.fail("V1 Now Playing style did not restore") @@ -721,11 +726,16 @@ ShellRoot { panel.v2LayoutActive = true if (!appearance.openWidgetDetails("G9", "") || appearance.selectedWidgetMode !== "default" + || appearance.selectedWidgetModeOptions.length !== 2 + || appearance.selectedWidgetModeOptions[0].value !== "default" + || appearance.selectedWidgetModeOptions[0].label !== "Default" + || appearance.selectedWidgetModeOptions[1].value !== "full" + || appearance.selectedWidgetModeOptions[1].label !== "Compact" || !appearance.cycleSelectedWidgetMode() || appearance.selectedWidgetMode !== "full" || stateService.groupAppearanceSettingForVariant( "G9", "v1", "mediaStyle", "") !== "default") - return root.fail("V2 Now Playing style contract drifted") + return root.fail("V2 Now Playing Default/Compact contract drifted") if (!appearance.openWidgetDetails("G4", "") || appearance.selectedWidgetMode !== "full") return root.fail("V2 appearance did not remain independent")