refactor: move package execution facts to review boundary

Author: olwang

crates/rsscript-compiler/src/package.rs

@@ -39,7 +39,9 @@ pub(super) use rsscript_project::{
 mod analysis;
 #[path = "package/review/review_await.rs"]
 mod analysis_await;
-mod analysis_execution;
+mod analysis_execution {
+    pub(super) use rsscript_package_review::*;
+}
 mod authorization;
 mod check;
 // Contract extraction is review-owned. Keep only a private compatibility

…mpiler/src/package/analysis_execution.rs …pt-package-review/src/execution_facts.rscrates/rsscript-compiler/src/package/analysis_execution.rs renamed to crates/rsscript-package-review/src/execution_facts.rs crates/rsscript-compiler/src/package/analysis_execution.rs renamed to crates/rsscript-package-review/src/execution_facts.rs

@@ -1,15 +1,16 @@
 use std::collections::BTreeSet;
 
-use crate::syntax::ast::{Block, Callee, DataEffect, Expr, Item, Stmt};
+use rsscript_syntax::ast::{Block, Callee, DataEffect, Expr, Item, Stmt};
 
-use super::{
+use crate::PackageSource;
+use rsscript_package_model::{
     PackageAnalysisResourceLifetime, PackageAnalysisResourceTransfer, PackageAnalysisTaskGroup,
-    PackageReviewFileKind, PackageSource,
+    PackageReviewFileKind,
 };
 
-pub(super) fn collect_execution_facts(
+pub fn collect_execution_facts(
     sources: &[PackageSource],
-    database: &crate::semantic::SemanticDatabase,
+    database: &rsscript_semantics::SemanticDatabase,
 ) -> (
     Vec<PackageAnalysisResourceLifetime>,
     Vec<PackageAnalysisResourceTransfer>,
@@ -366,7 +367,7 @@ fn count_select_arms(block: &Block) -> u32 {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::syntax::parse_source;
+    use rsscript_syntax::parse_source;
 
     #[test]
     fn records_only_explicit_take_of_with_binding_as_resource_transfer() {

crates/rsscript-package-review/src/lib.rs

@@ -6,9 +6,11 @@
 //! the compiler for semantic facts.
 
 mod contract;
+mod execution_facts;
 mod source_set;
 
 pub use contract::*;
+pub use execution_facts::*;
 pub use source_set::*;
 
 use std::collections::BTreeSet;

crates/rsscript-sdk/tests/architecture.rs

@@ -1907,10 +1907,15 @@ fn native_package_dependency_model_is_not_owned_by_aot_lowering() {
             && contract.contains("use rsscript_syntax::ast::"),
         "package contract extraction must use the review-owned session and syntax boundaries directly"
     );
-    let manifest_loader = function_source(
-        &source_set,
-        "pub fn load_package_manifest_with_source(",
+    let execution_facts_path = root.join("crates/rsscript-package-review/src/execution_facts.rs");
+    assert!(
+        execution_facts_path.is_file()
+            && !root
+                .join("crates/rsscript-compiler/src/package/analysis_execution.rs")
+                .exists(),
+        "package resource/task execution facts must be physically owned by the package-review boundary"
     );
+    let manifest_loader = function_source(&source_set, "pub fn load_package_manifest_with_source(");
     assert!(
         manifest_loader.contains("capture_project_manifest(package_dir, MANIFEST_MAX_BYTES)"),
         "package-review manifest semantics must consume project-captured manifest bytes"

docs/architecture/adr/0225-own-captured-package-review-inputs-outside-compiler.md

@@ -15,7 +15,8 @@ the compiler the physical owner of project/review input representation.
 `rsscript-package-review` owns the captured package manifest model,
 feature-selected source-set model, bounded loader, and source-level contract
 extractor. The latter calls `CompilationSession` and syntax directly rather
-than routing semantic facts through compiler-local helpers. The crate depends
+than routing semantic facts through compiler-local helpers. It also owns the
+neutral resource/task execution-fact collector used by package analysis. The crate depends
 on `rsscript-project` for confined/no-follow capture and on
 `rsscript-package-model` for versioned file-kind identity; it has no compiler
 dependency.

docs/architecture/migration-baseline.md

@@ -875,11 +875,12 @@ an arbitrary shell executor.
     captured package-review execution and its presentation still need to move
     to dedicated project/review/AOT crates before this item can close.
     The captured manifest/source-set representation and package contract
-    extractor are now physically owned by `rsscript-package-review`; its
-    extractor directly uses the semantic `CompilationSession` and syntax
-    boundary. Compiler package compatibility retains only private forwarding
-    modules while review execution, policy, lock/check/diff, and the public
-    compatibility façade continue their staged migration.
+    extractor, plus neutral resource/task execution-fact collection, are now
+    physically owned by `rsscript-package-review`; its extractor directly uses
+    the semantic `CompilationSession` and syntax boundary. Compiler package
+    compatibility retains only private forwarding modules while review
+    execution, policy, lock/check/diff, and the public compatibility façade
+    continue their staged migration.
     - [x] **S05.3a — Extract neutral risk facts and calculation.** The review
       risk lattice and its pure evidence evaluator now live in
       `rsscript-review-core`. Compiler compatibility code collects neutral