Update c++17 for pytorch 2.1.0#101
Conversation
|
Hi @HawkAaron @PoDuReM @IsaacTay @kamo-naoyuki, could you please help review this PR? Thank you! |
|
|
||
|
|
||
| extra_compile_args = ['-fPIC'] | ||
| if LooseVersion(torch.__version__) >= LooseVersion("1.5.0"): |
There was a problem hiding this comment.
What's the reason to use few c++ version? Why we can not use c++17 for any PyTorch version?
There was a problem hiding this comment.
PyTorch master has switched to C++17, need to update C++ version of this repo, otherwise, it will build fail. I have tested pytorch 1.10.0 and 1.13.0, C++17 works well. Suppose we can use C++17 for any PyTorch version.
| extra_compile_args += ['-std=c++17'] | ||
| else: | ||
| extra_compile_args += ['-std=c++11'] | ||
| extra_compile_args += ['-std=c++14'] |
There was a problem hiding this comment.
What about PyTorch versions less 1.5.0? Earlier c++11 used for these, now will be used c++14, is it ok?
There was a problem hiding this comment.
PyTorch version less 1.5.0 cannot run in my local platform. Since it is an old version, can we just use C++17 to cover all PyTorch version?
|
Hi @PoDuReM , could you please help review this PR? Thanks! |
I'm satisfied with this merge request |
|
Hi @HawkAaron @IsaacTay @kamo-naoyuki, could you please help review this PR and merge it? Thank you! |
2 participants
This PR is to update C++17 for PyTorch 2.1.0.