Deletes obsolete forks of nearspark, photomnemonic & dialog#395
Conversation
…rspark, photomnemonic & dialog Why: The main nearspark, photomnemonic & dialog repos have been updated with hubs-cloud changes & Mozilla branding replaced with Hubs Foundation
DougReeder
force-pushed
the
mozilla-branding-removal-Feb-B
branch
from
54d934e to
8054e55
Compare
Exairnous
left a comment
Exairnous
left a comment
There was a problem hiding this comment.
Thank you for the PR.
Changing Community Edition to use the Hubs Foundation's version of Dialog should be done in a separate PR.
The copies of hubs and reticulum shouldn't be edited here as they are going to be deleted. Note: the Reticulum repository's readme has already been updated, but the Hubs repository's .defaults.env could use the farspark mention removed.
The "Documentation of functionality" section in the PR description is to tell the reviewer where to find the changes you made to the documentation (either within this PR, or in another PR that you give the link to, e.g. in the hubs-docs repo), so this should direct people to the Community Edition readme and the readme should have a note that building services is undergoing a refactor and won't work right now.
Note: looking at the PR template in the .github repository, I realize the description for this section could use some improvement. Sorry about that.
The base of this PR should be the development branch, not master.
This PR still needs to be switched out of draft mode.
|
updated the PR description to reference the tracking issue (and the tracking issue to reference the PR in the correct spots). |
DougReeder
force-pushed
the
mozilla-branding-removal-Feb-B
branch
from
3d08361 to
986e8ae
Compare
Why: separate concerns
DougReeder
force-pushed
the
mozilla-branding-removal-Feb-B
branch
from
986e8ae to
ac2f622
Compare
Exairnous
left a comment
Exairnous
left a comment
There was a problem hiding this comment.
LGTM. Thanks! Merging.
Note: to reflect the current state of the PR, I removed the mention of the dialog image being replaced in the PR description.
2 participants
What?
Why?
The main nearspark, photomnemonic & dialog repos have been updated with hubs-cloud changes & Mozilla branding replaced with Hubs Foundation
Examples
no user-visible changes
How to test
Documentation of functionality
https://github.com/DougReeder/hubs-cloud/tree/mozilla-branding-removal-Feb-B/community-edition#building-from-source
Limitations
Dependencies need to be updated in separate PRs:
Hubs-Foundation/speelycaptor#20
Hubs-Foundation/photomnemonic#32
Hubs-Foundation/nearspark#33
Alternative implementations considered
none
Open questions
None
Additional details or related context
Part of #384