feat: Altium PORT connectivity and multi-channel expansion#52
Merged
Conversation
Match C++ reference behavior (StructLibraryPart.cpp:106-123) by peeking for 0x00 before each SymbolPin. Prevents parse failures and reader corruption on DSN files with convert-view pin placeholders.
…rser Add PORT (RECORD=18) as a globally-named connectable device so cross-sheet signals connect by name (like NET_LABEL/POWER_PORT). This fixes designs where signals cross sheet boundaries via PORT records (e.g., SHIELD_DETECT on pca10056). Add multi-channel expansion via PrjPCBStructure parsing. Repeated sheets (e.g., Repeat(AY,1,3)) are expanded into N channel instances with renamed components ($Component_$RoomName) and correctly classified nets: - Power nets: global (unchanged) - Shared SHEET_ENTRY signals: global (bus notation expanded, e.g., AD[0..7]) - Repeat() SHEET_ENTRY signals: per-channel suffix (e.g., CS -> CS_AY1) - Local nets: per-channel suffix Fixes #44.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44.
Verified
Test plan
npm run type-check && npm run lint && npm test(403 pass)