Make Conway CERTS test era-generic#5842
Conversation
|
The Dijkstra CERTS test still needs to be removed, or at least cut down |
|
Changelog and version updates are still needed |
4bdc004 to
50e19d8
Compare
|
|
||
| instance Ord (VKey kd) where | ||
| -- VerKeyDSIGN specifically disallows direct Ord | ||
| compare = comparing (DSIGN.rawSerialiseVerKeyDSIGN . unVKey) |
There was a problem hiding this comment.
This is the simplest solution I could come up with. Hashing is mentioned in the custom type error message, but this goes via rawSerialiseVerKeyDSIGN anyway.
lehins
left a comment
There was a problem hiding this comment.
I would like to ask you to add submitFailingTxSubset in a separate PR from Ord additions, if you could please.
I know this is a draft PR and you might have already planned on this, but I just wanted to make sure.
Also just a thought: maybe we should name it submitFailingSubsetTx instead? This way the "Subset" would be more relevant to "Failing" instead of "Tx`, which is what the intention of this function is.
Done, as #5850, although still a draft as it requires a new release of |
Yep, new release is coming soon. Probably tomorrow, since there are a few other things we want to release from there |
50e19d8 to
0d42a1f
Compare
Description
The Conway CERTS test produces additional predicate failures in Dijkstra, so previously it was necessary to duplicate the code in a separate test for Dijkstra. By introducing a new test helper,
submitFailingTxSubset, it's possible for the Conway test to check that the given predicate failures are a subset of those actually produced, ie that all of the given failures are present. This enables the test to run in all post-Conway eras.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).