Skip to content

decodeSparseKeyed for more types#5847

Open
aniketd wants to merge 11 commits into
masterfrom
aniketd/coders-safe
Open

decodeSparseKeyed for more types#5847
aniketd wants to merge 11 commits into
masterfrom
aniketd/coders-safe

Conversation

@aniketd
Copy link
Copy Markdown
Contributor

@aniketd aniketd commented May 19, 2026

Description

This is part of the implementation for #5718

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@aniketd aniketd requested a review from a team as a code owner May 19, 2026 15:14
@aniketd aniketd requested review from lehins and teodanciu May 19, 2026 15:14
@aniketd aniketd force-pushed the aniketd/coders-safe branch from d8dab6a to 01bde52 Compare May 20, 2026 10:51
Copy link
Copy Markdown
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some comments about naming from me.

Comment thread eras/babbage/impl/src/Cardano/Ledger/Babbage/TxOut.hs Outdated
Comment thread eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxAuxData.hs
Comment thread libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs Outdated
Comment thread libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs Outdated
Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxBody.hs Outdated
Copy link
Copy Markdown
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice. Suggested a few improvements that should simplify this somewhat

Comment thread eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxAuxData.hs Outdated
Comment thread eras/babbage/impl/src/Cardano/Ledger/Babbage/TxOut.hs Outdated
Comment thread libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs Outdated
Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxBody.hs Outdated
Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxBody.hs Outdated
Comment thread libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs Outdated
Comment thread libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs Outdated
Comment thread eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxWits.hs Outdated
Comment thread eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxWits.hs Outdated
Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxBody.hs Outdated
@aniketd aniketd force-pushed the aniketd/coders-safe branch from 6b4a146 to b6277b5 Compare May 21, 2026 16:10
@aniketd aniketd requested review from lehins and teodanciu May 21, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants