Add ToJSON/FromJSON instances for EraTxAuxData#5853
Open
koslambrou wants to merge 1 commit into
Open
Conversation
koslambrou
force-pushed
the
koslambrou/eratxauxdata-json
branch
from
e774714 to
7cb4022
Compare
koslambrou
commented
May 20, 2026
|
|
||
| instance Typeable era => NoThunks (Data era) | ||
|
|
||
| instance ToJSON (Data era) where |
Contributor
Author
There was a problem hiding this comment.
These instance implementations come from cardano-api analogous ScriptData datatype.
koslambrou
commented
May 20, 2026
| instance DecCBOR Metadatum where | ||
| decCBOR = decodeMetadatum | ||
|
|
||
| instance ToJSON Metadatum where |
Contributor
Author
There was a problem hiding this comment.
These instance implementations come from cardano-api's analogous datatype TxMetadata
koslambrou
force-pushed
the
koslambrou/erascript-json
branch
from
e91e67d to
64fada4
Compare
koslambrou
force-pushed
the
koslambrou/eratxauxdata-json
branch
2 times, most recently
from
edd3dc5 to
78c3261
Compare
koslambrou
force-pushed
the
koslambrou/erascript-json
branch
from
64fada4 to
a015bf1
Compare
koslambrou
force-pushed
the
koslambrou/eratxauxdata-json
branch
2 times, most recently
from
b22f263 to
6795448
Compare
lehins
requested changes
May 21, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Looks like good progress 👍
| metadata <- o .: "metadata" | ||
| nativeScripts <- StrictSeq.fromList <$> o .: "nativeScripts" | ||
| plutusScriptsRaw <- o .: "plutusScripts" | ||
| let plutusScripts = Map.mapMaybe NE.nonEmpty plutusScriptsRaw |
Collaborator
There was a problem hiding this comment.
Ok, so this by itself is not going to work, because it would allow addition of Plutus scripts of an unsupported version for a particular era. See the pattern synonym AlonzoTxAuxData. So, what we need to do is extract the construction logic into a mkAlonzoTxAuxData function with MonadFail constraint, then it would be usable here in FromJSON instance as well as in AlonzoTxAuxData pattern synonym with errorFail from FailT package.
Contributor
Author
There was a problem hiding this comment.
Good catch!
There's already a mkAlonzoTxAuxData and a mkBinaryPlutusScript which has MonadFail. So the following works:
parseJSON = withObject "AlonzoTxAuxData" $ \o -> do
metadata <- o .: "metadata"
nativeScripts <- o .:? "nativeScripts" .!= mempty
plutusScriptsLangMap <- o .:? "plutusScripts" .!= mempty
plutusScripts <-
fmap concat $ forM (Map.toList plutusScriptsLangMap) $ \(lang, plutusScripts) ->
traverse (fmap PlutusScript . mkBinaryPlutusScript lang) plutusScripts
pure $ mkAlonzoTxAuxData metadata $ fmap NativeScript nativeScripts <> plutusScripts
Are you satisfied with that?
koslambrou
force-pushed
the
koslambrou/erascript-json
branch
2 times, most recently
from
16ca7eb to
ca7aa7b
Compare
koslambrou
force-pushed
the
koslambrou/eratxauxdata-json
branch
2 times, most recently
from
547933d to
f654838
Compare
* Add ToJSON/FromJSON and NFData as EraTxAuxData superclass constraints * Add ToJSON/FromJSON for Metadatum * Add ToJSON/FromJSON for Data era and PlutusBinary * Add FromJSON for PoolCert, ConwayGovCert, DijkstraDelegCert, DijkstraTxCert era * Add ToJSON/FromJSON for ShelleyTxAuxData, AllegraTxAuxData, AlonzoTxAuxData * Add round-trip JSON property test for TxAuxData era
koslambrou
force-pushed
the
koslambrou/eratxauxdata-json
branch
from
f654838 to
e45b5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).