feat: upgrade sdk modules#42
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the SDK modules to improve the architecture by refactoring the wallet functionality, expanding provider capabilities, and restructuring the type system for better modularity.
- Modularizes wallet functionality by extracting derivation logic and introducing new service patterns
- Expands provider interfaces to support additional UTxO queries, delegation, and transaction evaluation
- Restructures module exports and type definitions for improved API consistency
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evolution/test/WalletFromSeed.test.ts | Updates import path to use new wallet utils module |
| packages/evolution/src/sdk/wallet/WalletService.ts | New Effect-based wallet service implementation |
| packages/evolution/src/sdk/wallet/Wallet.ts | Refactored to use extracted derivation utilities and new interfaces |
| packages/evolution/src/sdk/wallet/Derivation.ts | New module containing seed and key derivation utilities |
| packages/evolution/src/sdk/provider/types.ts | Removed provider types (moved to specific modules) |
| packages/evolution/src/sdk/provider/internal/Ogmios.ts | Fixed optional chaining for datum option |
| packages/evolution/src/sdk/provider/internal/HttpUtils.ts | Added FetchHttpClient layer and simplified type parameters |
| packages/evolution/src/sdk/provider/Provider.ts | Expanded with comprehensive provider interface methods |
| packages/evolution/src/sdk/provider/KupmiosService.ts | New comprehensive Effect-based provider service |
| packages/evolution/src/sdk/provider/Kupmios.ts | Refactored to use new service module |
| packages/evolution/src/sdk/index.ts | Added exports for new modules |
| packages/evolution/src/sdk/UTxO.ts | Updated to use modular Datum and OutRef types |
| packages/evolution/src/sdk/ProtocolParameters.ts | New module for protocol parameters types and utilities |
| packages/evolution/src/sdk/OutRef.ts | New module for transaction output reference utilities |
| packages/evolution/src/sdk/EvalRedeemer.ts | New module for transaction evaluation types |
| packages/evolution/src/sdk/Delegation.ts | New module for stake delegation utilities |
| packages/evolution/src/sdk/Datum.ts | New module for datum types and utilities |
| package.json | Added Effect language service dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…interfaces (types only)
- Implement Value.geq() function to support >= comparisons between Values - Copy all builder files from main branch (TxBuilder, CertificateBuilder, etc.) - Update TxBuilder.ts to use Value.geq() method instead of undefined method - Fixes CI build failures where Value.geq() was being called but not defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.