-
Notifications
You must be signed in to change notification settings - Fork 15
Incomplete removal of timer voice channel #43
Copy link
Copy link
Open
Labels
RequestedRequested features or bugfixesRequested features or bugfixesbugSomething isn't workingSomething isn't workingbugscope:minorBug doesn't affect most users or featuresBug doesn't affect most users or featuresdifficulty:easyStraightforward, minimal structural knowledge neededStraightforward, minimal structural knowledge neededmodule:timer-coreTimer module core functionality (timers, subscribers, timerchannels, etc)Timer module core functionality (timers, subscribers, timerchannels, etc)
Description
Activity
Metadata
Metadata
Assignees
Labels
RequestedRequested features or bugfixesRequested features or bugfixesbugSomething isn't workingSomething isn't workingbugscope:minorBug doesn't affect most users or featuresBug doesn't affect most users or featuresdifficulty:easyStraightforward, minimal structural knowledge neededStraightforward, minimal structural knowledge neededmodule:timer-coreTimer module core functionality (timers, subscribers, timerchannels, etc)Timer module core functionality (timers, subscribers, timerchannels, etc)
Issue
Unsetting the voice channel using
,ptconfig voice_channel Nonedoes not remove the voice channel from the timer (e.g. the timer continues giving voice alerts).Proposed Solution
Ref: https://github.com/Intery/PomoBot/blob/rewrite/bot/Timer/core.py#L431
The
Timer.load()method, called by the timer config setter, should reset the voice channel when the voice channel id is None.