Skip to content

BuildResolver.AddParamAndChildren can attempt to add params that haven't been added to the build #369

Description

@DecSmith42

An example of this is when using .RequiresParam(nameof(IAzureArtifactStorage.AzureArtifactStorageConnectionString)) on a target without actually setting IAzureArtifactStorage as an interface of the build.

This can cause the BuildResolver to lookup AzureArtifactStorageConnectionString in the paramModels map and run into KeyNotFoundException.

The fix should be something along the lines of:

Print a more useful indication of why the error happens when we encounter it and exit the build (instead of just exiting due to KeyNotFoundException

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions