Format long one-line boolean checks to if statements

[sethaxen]

It would be useful to have something like short_to_long_function_def for boolean checks. Currently statements like this

function foo()
    my_really_really_really_long_boolean_check() && return my_really_really_really_long_function_name()
end

get formatted to this, so the result is separated from the conditional:

function foo()
    my_really_really_really_long_boolean_check() &&
    return my_really_really_really_long_function_name()
end

But I would like an option for it to be formatted to this:

function foo()
    if my_really_really_really_long_boolean_check()
        return my_really_really_really_long_function_name()
    end
end

Likewise this:

function foo()
    my_really_really_really_long_boolean_check() || return my_really_really_really_long_function_name()
    return 1
end

should be formatted to this:

function foo()
    if !my_really_really_really_long_boolean_check()
        return my_really_really_really_long_function_name()
    end
    return 1
end

[domluna]

This looks cool.

Indenting has also been brought up in this case

so

function foo()
    my_really_really_really_long_boolean_check() && return my_really_really_really_long_function_name()
end

would be

function foo()
    my_really_really_really_long_boolean_check() &&
        return my_really_really_really_long_function_name()
end

? for this other approach would be should only the last arg be indented or all args after the first arg

[sethaxen]

Good question, I think all args that are part of the same statement would be indented. @mateuszbaran, do you have any thoughts?

[mateuszbaran]

I also think all parts should be indented, like here:

function foo()
    my_first_really_really_long_boolean_check() &&
        my_second_really_really_long_boolean_check() &&
        return my_really_really_really_long_function_name()
end

[penelopeysm]

short_circuit_to_if exists now:

julia> s = """
       function foo()
           my_really_really_really_long_boolean_check() && return my_really_really_really_long_function_name()
           return 1
       end"""
"function foo()\n    my_really_really_really_long_boolean_check() && return my_really_really_really_long_function_name()\n    return 1\nend"

julia> format_text(s; short_circuit_to_if=true) |> println
function foo()
    if my_really_really_really_long_boolean_check()
        return my_really_really_really_long_function_name()
    end
    return 1
end