Skip to content

do not load_command_class #5

Description

@bartekbrak

utils.py:sync_commands instantiates all Command objects via load_command_class. I say this is harmful, a user (my case) might do expensive operations in given commands __init__, the loaded class is not used except for its help which can be obtained without instantiation.

What do you think?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions