Which package?
@termuijs/jsx
What happened?
Errors thrown during app.unmount() are silently swallowed during cleanup.
Currently the cleanup helper wraps app.unmount() in an empty catch block:
try {
app.unmount();
} catch {}
As a result, cleanup failures are completely hidden from developers, making unmount-related issues difficult to diagnose.
Expected behavior:
- Cleanup should continue even if an individual
unmount() call fails.
- The error should be logged so developers can understand why cleanup failed.
Actual behavior:
- Errors are silently ignored with no logging or diagnostics.
Steps to reproduce
const app = {
unmount() {
throw new Error('Unmount failed');
}
};
// Trigger the cleanup path that invokes app.unmount()
Observe that the error is swallowed and no diagnostic output is produced.
Environment
- Bun version: 1.x
- OS: Linux (WSL)
- Terminal emulator: Windows Terminal
- TermUI version: Latest main branch
Screenshots or terminal output
Current behavior:
Expected behavior:
[jsx] Error during unmount(): Error: Unmount failed
GSSoC contributor?
Which package?
@termuijs/jsx
What happened?
Errors thrown during
app.unmount()are silently swallowed during cleanup.Currently the cleanup helper wraps
app.unmount()in an empty catch block:As a result, cleanup failures are completely hidden from developers, making unmount-related issues difficult to diagnose.
Expected behavior:
unmount()call fails.Actual behavior:
Steps to reproduce
Observe that the error is swallowed and no diagnostic output is produced.
Environment
Screenshots or terminal output
Current behavior:
Expected behavior:
GSSoC contributor?