From eab6e0d61c3164456416fcf37286a1b8dfd79300 Mon Sep 17 00:00:00 2001 From: Kpa-clawbot Date: Tue, 16 Jun 2026 19:11:16 +0000 Subject: [PATCH] =?UTF-8?q?fix(#1718):=20drop=20prefix-tool=20a11y=20allow?= =?UTF-8?q?list=20entries=20=E2=80=94=20subsumed=20by=20#1720?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #1720 consolidated active button states (incl. `.btn-active-accent`) onto `var(--accent-strong)` + `var(--text-on-accent)` (4.95:1, WCAG AA). The `#ptCheckBtn` / `#ptGenBtn` color-contrast violations that issue #1718 tracked are gone, so the allowlist entries are stale. Drops the two `issue: 1718` entries from `tests/a11y-allowlist.yaml`: ```yaml - route: '/analytics?tab=prefix-tool' selector: '#ptCheckBtn' rule: color-contrast issue: 1718 expires_at: 2026-09-11 - route: '/analytics?tab=prefix-tool' selector: '#ptGenBtn' rule: color-contrast issue: 1718 expires_at: 2026-09-11 ``` No other tabs touched (#1715 dark-theme work remains — separate issue). ## Verification The CI a11y gate (`test-a11y-axe-1668.js`) is the authoritative check. It re-renders `/analytics?tab=prefix-tool` in dark+light × desktop+ mobile and asserts zero net violations against the trimmed allowlist. With this PR the entries are gone — if PR #1720's fix were ever reverted, the gate fails immediately with no allowlist masking it. Local repro not attempted: sandbox chromium lacks the `@axe-core/playwright` module (matches the documented limitation in PR #1730 / PR #1723). CI is the source of truth. ## TDD note Config-change exemption per workspace AGENTS.md: - No test files modified. - No production code modified. - Config-only allowlist trim; CI must stay green without test edits. - The gate itself is the test — dropping the allowlist entries IS the red→green transition (entries gone → axe runs unfiltered → must remain pass because #1720 fixed the root cause). Mirrors the exact pattern accepted in PR #1722, PR #1723, PR #1730 and PR #1731 (same allowlist-drop shape, same upstream PR #1720 fix). Fixes #1718. Refs PR #1720, PR #1731. --- tests/a11y-allowlist.yaml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/tests/a11y-allowlist.yaml b/tests/a11y-allowlist.yaml index c99eb1c2..0a3de72b 100644 --- a/tests/a11y-allowlist.yaml +++ b/tests/a11y-allowlist.yaml @@ -58,13 +58,3 @@ strict_unused: false rule: color-contrast issue: 1715 expires_at: 2026-09-11 -- route: '/analytics?tab=prefix-tool' - selector: '#ptCheckBtn' - rule: color-contrast - issue: 1718 - expires_at: 2026-09-11 -- route: '/analytics?tab=prefix-tool' - selector: '#ptGenBtn' - rule: color-contrast - issue: 1718 - expires_at: 2026-09-11