Description
Comment says "remove existing limit and add updated one" but the test code only adds a new updated limit. The test assertion only checks the new limit exists, not that default was removed.
Current Behaviour
// remove existing limit and add updated one ← comment says "remove"
await page.getByRole('button', { name: 'Add Limit' }).click();
// ... adds 'updated' limit ...
expect(
kubectl(['get', 'tokenratelimitpolicy', policyName, '-n', namespace, '-o', 'jsonpath={.spec.limits.updated.rates[0].limit}'])
).toBe('200');
// ❌ No assertion that 'default' was removedExpected Behaviour
Option 1: Update comment to match behavior:
// add the updated limit; the form replaces previous limits on save
Option 2: Add assertion that old limit is gone:
expect(
kubectl(['get', 'tokenratelimitpolicy', policyName, '-n', namespace, '-o', 'jsonpath={.spec.limits.default}'])
).toBe('');Location
e2e/tests/policy-forms.spec.ts:818-845
Related
CodeRabbit comment in PR #734
Description
Comment says "remove existing limit and add updated one" but the test code only adds a new
updatedlimit. The test assertion only checks the new limit exists, not thatdefaultwas removed.Current Behaviour
Expected Behaviour
Option 1: Update comment to match behavior:
// add the updated limit; the form replaces previous limits on saveOption 2: Add assertion that old limit is gone:
Location
e2e/tests/policy-forms.spec.ts:818-845Related
CodeRabbit comment in PR #734