Skip to content

[Backend] Webhook subscriptions accept any URL, enabling SSRF to internal services #3

Description

@grantfox-oss

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

Webhook registration in src/controllers/indexerController.ts (lines 494-520) only validates that callbackUrl parses and uses http/https. There is no block on loopback, link-local (169.254.169.254), or RFC1918 ranges, so an authenticated caller can make the indexer POST to internal services or cloud metadata endpoints.

Acceptance criteria

  • Reject callback URLs that resolve to loopback, link-local, RFC1918 or other reserved ranges at registration time
  • Re-validate the resolved address at delivery time in webhookService to defend against DNS rebinding
  • Add tests covering 127.0.0.1, 169.254.169.254 and a 10.x host being rejected
  • Document the allowed/blocked URL policy

Files to touch

  • src/controllers/indexerController.ts
  • src/services/webhookService.ts

Out of scope

  • Building an allowlist UI
  • Outbound proxy infrastructure

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial CampaignCampaign: Official CampaignbugSomething isn't workingenhancementNew feature or requesthardAdvanced / high-difficulty issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions