From 483294c73ec7adeb5f4809f1cbdb40bf98a6914f Mon Sep 17 00:00:00 2001 From: Yorick de Wid Date: Fri, 22 May 2026 15:41:47 +0000 Subject: [PATCH] chore: fix broken dev tooling and dead CI/doc references MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Conservative dev-tooling/doc hygiene (this is the live C# backend): - .vscode/launch.json: drop the FunderMaps.WsClient debug config (project no longer exists in src/), and fix the Webservice + WebApi program paths from net8.0 → net10.0 (all csproj target net10.0, so F5 debug was pointing at a non-existent DLL). - .github/workflows/dotnet-core.yml: remove the two commented-out test jobs targeting FunderMaps.IntegrationTests.{Portal,Webservice} — neither project exists. The active FunderMaps.Webservice.Tests job is untouched. - README.md: `contrib/etc/` is a directory of files, not a single `_appsettings.{ENV}.json` "directory" — reworded. Deliberately left untouched (need your call): - scripts/deploy.sh publishes src/FunderMaps.Worker/, which moved to the FunderMapsWorker repo — the correct publish target for this script is a deployment decision, not a mechanical fix. - .github/workflows/codeql-analysis.yml has every analysis step commented out (only checkout runs) — re-enable vs delete is a CI-policy call. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/dotnet-core.yml | 26 -------------------------- .vscode/launch.json | 23 ++--------------------- README.md | 2 +- 3 files changed, 3 insertions(+), 48 deletions(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 3078398ce..8cdac47af 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -55,29 +55,3 @@ jobs: Authentication__Cookie__Domain: localhost DataProtection__ApplicationName: FunderMapsTest ConnectionStrings__FunderMapsConnection: "Server=localhost;Database=fundermaps;User Id=fundermaps_webapp" - - # - name: Testing Portal - # run: dotnet test --nologo --configuration ${{ env.BUILD_CONFIG }} --no-restore --filter FunderMaps.IntegrationTests.Portal - # env: - # ASPNETCORE_ENVIRONMENT: Production - # UseExternalServices: False - # Jwt__Issuer: "FunderMapsTest" - # Jwt__Audience: "FunderMapsTest" - # Jwt__TokenValidity: 10 - # Jwt__SignatureKey: somelargetextstringusedinsignatures - # Incident__ClientId: 42 - # Incident__Recipients__0: info@example.com - # ConnectionStrings__FunderMapsConnection: "Server=localhost;Database=fundermaps;User Id=fundermaps_portal" - - # - name: Testing Webservice - # run: dotnet test --nologo --configuration ${{ env.BUILD_CONFIG }} --no-restore --filter FunderMaps.IntegrationTests.Webservice - # env: - # ASPNETCORE_ENVIRONMENT: Production - # UseExternalServices: False - # Jwt__Issuer: "FunderMapsTest" - # Jwt__Audience: "FunderMapsTest" - # Jwt__TokenValidity: 10 - # Jwt__SignatureKey: somelargetextstringusedinsignatures - # Incident__ClientId: 42 - # Incident__Recipients__0: info@example.com - # ConnectionStrings__FunderMapsConnection: "Server=localhost;Database=fundermaps;User Id=fundermaps_webservice" diff --git a/.vscode/launch.json b/.vscode/launch.json index 43a1bd3b2..bbe7d15a4 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -1,25 +1,6 @@ { "version": "0.2.0", "configurations": [ - { - // Use IntelliSense to find out which attributes exist for C# debugging - // Use hover for the description of the existing attributes - // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md - "name": "FunderMaps.WsClient", - "type": "coreclr", - "request": "launch", - "preLaunchTask": "build", - // If you have changed target frameworks, make sure to update the program path. - "program": "${workspaceFolder}/src/FunderMaps.WsClient/bin/Debug/net8.0/FunderMaps.WsClient.dll", - "args": [], - "cwd": "${workspaceFolder}/src/FunderMaps.WsClient", - // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console - "console": "integratedTerminal", - "stopAtEntry": false, - "env": { - "ASPNETCORE_ENVIRONMENT": "Development" - } - }, { // Use IntelliSense to find out which attributes exist for C# debugging // Use hover for the description of the existing attributes @@ -29,7 +10,7 @@ "request": "launch", "preLaunchTask": "build", // If you have changed target frameworks, make sure to update the program path. - "program": "${workspaceFolder}/src/FunderMaps.Webservice/bin/Debug/net8.0/FunderMaps.Webservice.dll", + "program": "${workspaceFolder}/src/FunderMaps.Webservice/bin/Debug/net10.0/FunderMaps.Webservice.dll", "args": [], "cwd": "${workspaceFolder}/src/FunderMaps.Webservice", // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console @@ -48,7 +29,7 @@ "request": "launch", "preLaunchTask": "build", // If you have changed target frameworks, make sure to update the program path. - "program": "${workspaceFolder}/src/FunderMaps.WebApi/bin/Debug/net8.0/FunderMaps.WebApi.dll", + "program": "${workspaceFolder}/src/FunderMaps.WebApi/bin/Debug/net10.0/FunderMaps.WebApi.dll", "args": [], "cwd": "${workspaceFolder}/src/FunderMaps.WebApi", // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console diff --git a/README.md b/README.md index da4ca4f83..850c15f7b 100644 --- a/README.md +++ b/README.md @@ -39,7 +39,7 @@ When using VS Code the 'debug' section should list all the applications. Just ru ## Configuration -See the `contrib/etc/_appsettings.{ENV}.json` directory for configuration files for each environment. You can copy these configuration files to the project source directory (`src/{project}`). +See `contrib/etc/` for the `_appsettings.{ENV}.json` configuration files for each environment. You can copy these configuration files to the project source directory (`src/{project}`). ## Using the application