From 5b7c1cd23d735e6658a9af7344d1583c009cc77b Mon Sep 17 00:00:00 2001 From: Yorick de Wid Date: Tue, 28 Jul 2026 20:26:47 +0000 Subject: [PATCH] fix(invoer): drop the "adressen missen een funderingstype" check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A sample records what a report observed, and plenty of reports observe an address without ever establishing its foundation type. Treating that as an incomplete dossier was wrong on the facts, and it showed up twice: - Controle (step 3): an amber callout claiming the address "werkt niet door in de kaart en de producten", plus the same sentence repeated in the submit confirm dialog. Both gone; `isClean` no longer requires a foundation type, so these dossiers now get the green "klaar om aan te bieden" callout they always deserved. - Dossier view: a `blocker` telling people the dossier could not go to review until the field was filled. Gone; it now falls through to the generic pipeline sentence. The "N met funderingstype" stat on the dossier view stays — that is a count, not a complaint. Co-Authored-By: Claude Opus 5 (1M context) --- src/views/inquiry/InquiryStep3.vue | 32 ++++++++---------------------- src/views/inquiry/InquiryView.vue | 6 +----- 2 files changed, 9 insertions(+), 29 deletions(-) diff --git a/src/views/inquiry/InquiryStep3.vue b/src/views/inquiry/InquiryStep3.vue index befda48..5946714 100644 --- a/src/views/inquiry/InquiryStep3.vue +++ b/src/views/inquiry/InquiryStep3.vue @@ -34,9 +34,12 @@ import { useStudioStore } from '@/stores/studio' * * The last chance to catch something before a reviewer's time is spent on it, * so the page leads with what is *wrong* rather than with what is there: empty - * addresses, missing foundation types, and every cross-field finding across the - * whole dossier collected into one list. Below that, the dossier as the - * reviewer will see it. + * addresses and every cross-field finding across the whole dossier collected + * into one list. Below that, the dossier as the reviewer will see it. + * + * A missing foundation type is *not* one of those wrongs — a sample records what + * the report observed, and plenty of reports observe an address without ever + * establishing its foundation type. */ const route = useRoute() const router = useRouter() @@ -86,10 +89,6 @@ const emptyAddresses = computed(() => samples.value.filter((s) => countFilledSampleFields(s) === 0), ) -const withoutFoundationType = computed(() => - samples.value.filter((s) => s.foundationType === null), -) - /** * Every cross-field finding in the dossier, tagged with the address it belongs * to. Collected here rather than left in the editor because this is the moment @@ -109,7 +108,6 @@ const isClean = computed( () => samples.value.length > 0 && !emptyAddresses.value.length && - !withoutFoundationType.value.length && !findings.value.length, ) @@ -136,9 +134,6 @@ async function submit() { if (emptyAddresses.value.length) { warnings.push(`${emptyAddresses.value.length} adres(sen) zijn nog helemaal leeg.`) } - if (withoutFoundationType.value.length) { - warnings.push(`${withoutFoundationType.value.length} adres(sen) missen een funderingstype.`) - } if (findings.value.length) { warnings.push(`${findings.value.length} waarde(n) zijn nog niet gecontroleerd.`) } @@ -210,8 +205,8 @@ useActionShortcuts((): Record void> => - Alle {{ samples.length }} adressen zijn gevuld, hebben een funderingstype en er zijn geen - waarden die elkaar tegenspreken. + Alle {{ samples.length }} adressen zijn gevuld en er zijn geen waarden die elkaar + tegenspreken. - - Zonder funderingstype werkt het adres niet door in de kaart en de producten. - - -
  • nextStep(status.value)) */ const blocker = computed(() => { if (!canSubmitForReview.value) return null - const { total, withFoundationType, empty } = completeness.value + const { total, empty } = completeness.value if (total === 0) return 'Dit dossier heeft nog geen adressen. Voeg er minstens één toe in stap 2.' if (empty > 0) { return empty === 1 ? '1 van de adressen is nog helemaal leeg. Zodra dat gevuld is kan het dossier ter controle.' : `${empty} van de ${total} adressen zijn nog helemaal leeg. Zodra die gevuld zijn kan het dossier ter controle.` } - const missing = total - withFoundationType - if (missing > 0) { - return `${missing} van de ${total} adressen mist een funderingstype. Zodra dat gevuld is kan het dossier ter controle.` - } return null })