Macros expand incorrectly when using files from the base AU mod

[cryptonaut]

TL;DR:

Macros expand incorrectly due to #defines being set differently by PCF and the base mod.

e.g. GVAR(myVar) expands into a3ue_pcf_core_myVar instead of A3A_core_myVar which breaks various things.

---

I was having an issue where the terrain manipulators (smooth terrain, clear vegetation, etc) that you can build weren't loading from a persistent save correctly. When loading a save with PCF loaded terrain manipulator objects would show up as floating blue arrows and wouldn't apply the smoothing etc that they were supposed to.

After buildings are loaded from a save they are supposed to run a handler function here:

A3UEPCF/a3ue_pcf/addons/core/functions/Save/fn_loadStat.sqf

Lines 412 to 415 in 93cfe74

	if isText(configOf _veh >> QGVAR(onBuildingLoaded)) then {
	Debug_3("calling %1 on %2 with params %3", QGVAR(onBuildingLoaded), typeOf _veh, [_veh]);
	[_veh] call compile getText(configOf _veh >> QGVAR(onBuildingLoaded));
	};

Notice the macro QGVAR(onBuildingLoaded) which expands to something like: PREFIX_COMPONENT_onBuildingLoaded.

When the file is loaded in the base AU mod PREFIX is set to A3A and so the function name expands to A3A_core_onBuildingLoaded.

However, when the file is loaded in PCF, it's #includeing it's own script_mod.hpp file which sets PREFIX to a3ue_pcf and so it expands into a3ue_pcf_core_onBuildingLoaded instead! Since that's not a valid handler name, no function gets called and stuff breaks.

A simple fix might be to set PREFIX to A3A so that the macros expand correctly in those files (this is what I did in a personal build and it seems to work fine):

#define PREFIX A3A
#include "..\..\script_component.hpp"
FIX_LINE_NUMBERS()

Or to possibly include the script_component.hpp from the base mod using something like #include "\x\A3A\addons\core\script_component.hpp" but I'm not sure if that could cause other issues.

Note this is kind of a hack though, so it needs some more looking into for a proper fix.

[Land-Strider]

Thank your such a detailed debug work. I didn't have to do much besides following it.

As for the change, I had opted to keep the deprecated MODNAME preprocessor defintion for function path macros, so I no longer need to change the PREFIX to definition for this extender function path macros in COMPONENT_NAME. Changing the COMPONENT_NAME definition is a bit of a hack in itself, but so far it is only used and intended to be used for package build scripts, which is per-mod anyway. This should prove more consistent, compared to overriding the PREFIX back to A3A in everywhere needed but leaving it a3ue_pcf anywhere not used.

Another alternative was completely getting rid of MODNAME and the related changes, and using overt paths. This may prove other issues in different environments, so opted for the option above.

A note: Build Box terrain smoother and other new modules (vegetation and terrain cleaner) saving has still a critical bug in the base AU mod. They are saved once when built, but they are no longer kept again in future saves after a load. AU team has fixed this and will include it in the upcoming patch.

I did very limited testing, but for now the blue marker should be gone, and the terrain smoothing (and other modules) should be loaded in the next session (but not in subsequent load/save sessions as per the note above).

Labeling the issue testing and keeping open till the next update.

[cryptonaut]

Sounds good! I totally forgot to mention the bug in the base mod that causes the terrain manipulator etc to not save/load correctly as well. I was going to explain that in my post but somehow forgot to include that.

Thanks for the quick fix and for the great mod!