-
-
Notifications
You must be signed in to change notification settings - Fork 39
Open
Description
I noticed two issues in usePanResponders.tsx
- volumePanResponder and seekPanResponder never clear the interaction handle created when responder was granted. Any code in
InteractionManager.runAfterInteractionsis blocked after changing volume or seek bar. PanResponder.createwas called repeatedly(hundreds and hundreds times) while video was playing or when changing volume.
The main reason is that the PanResponder.create is not wrapped in useMemo, so they are re-created every time when the VideoPlayer is refreshed.
I created a patch file to resolve this for now. https://gist.github.com/Yupeng-li/78d04099f0ee20bbf164c6d7e99eb2df
Metadata
Metadata
Assignees
Labels
No labels