* Add daily hard price refresh at configurable UTC time (issue #366) Dynamic tariff data (e.g. EPEX Spot next-day prices) is published around 12:00-13:00 UTC. The existing hourly fail-safe scheduler may not pick up fresh data promptly. This change adds a dedicated daily hard refresh that bypasses the cache and always fetches from the provider. Changes: - dynamictariff/baseclass.py: Add force=True parameter to refresh_data() to bypass next_update_ts and always fetch fresh data. - scheduler.py: Add optional tz parameter to schedule_at() / SchedulerThread to support timezone-aware daily scheduling via schedule library. - core.py: Read market_price_refresh_time from battery_control_expert config (default "12:30" UTC) and schedule a daily _hard_refresh_prices() call. - config/batcontrol_config_dummy.yaml: Add commented market_price_refresh_time option under battery_control_expert. - Tests: Cover force refresh behaviour, tz-aware schedule_at, and core wiring. * Validate market_price_refresh_time format at config load Add _validate_market_price_refresh_time() to catch invalid values like 'noon' or '25:99' early at startup with a clear error message, rather than failing silently at runtime when the scheduler tries to register the job. Addresses Copilot review comment on PR #367. * Fix interface/scheduler edge cases from Copilot review - dynamictariff_interface.py: Add force: bool = False to refresh_data() so TariffInterface matches DynamicTariffBaseclass and type checkers do not report a mismatch when core calls refresh_data(force=True). - scheduler.py: Normalize empty/whitespace tz to None in schedule_at() so logging and schedule.Job.at() behaviour are always consistent. An empty string is now treated identically to None (local time). - tests: Add edge-case tests for tz="" and tz=" " in schedule_at(). * Strip whitespace from tz in schedule_at() before forwarding to schedule The previous normalization checked tz.strip() to detect whitespace-only values but assigned the original tz (with spaces) to effective_tz. A value like ' UTC ' would pass the None-guard and be forwarded as-is to schedule.Job.at(), causing an UnknownTimeZoneError at runtime. Fix: assign tz.strip() instead of tz so the stripped value is used. Adds test for ' UTC ' (padded timezone string). Addresses Copilot review comment on PR #367. * Set wrapped_job.__name__ in schedule_at() and schedule_once() schedule_every() already sets wrapped_job.__name__ = name for consistent job identification in logs and schedule's job representation. Apply the same pattern to schedule_at() and schedule_once() for consistency across all scheduling helpers. Addresses Copilot review comment on PR #367. * Fix next_update_ts computed before sleep in refresh_data() now = time.time() was captured before the optional random delay, then used to set next_update_ts after the fetch. This shortened the effective min_time_between_updates by up to delay_evaluation_by_seconds seconds. Fix: use time.time() directly when setting next_update_ts so the timestamp reflects when the successful fetch actually completed. Pre-existing issue, addressed while modifying refresh_data() for #366. * Clear scheduled jobs on shutdown to prevent accumulation across restarts The module-level _job_registry is shared across Batcontrol instances in the same process. Without clearing jobs on shutdown, reconstructing Batcontrol (e.g. on restart) accumulates duplicate scheduled jobs and can trigger multiple forced price refreshes per cycle. Fix: call scheduler.clear_jobs() before stopping the scheduler thread in Batcontrol.shutdown(). Adds a test to verify the registry is empty after shutdown. Addresses Copilot review comment on PR #367. * Fix race condition: stop scheduler thread before clearing jobs clear_jobs() was called before stop(), which could race with the scheduler thread's run_pending() loop mutating the job list concurrently. schedule.Scheduler is not thread-safe. Fix: stop() (which joins the thread) first, then clear_jobs() once the thread has terminated. Addresses Copilot review comment on PR #367. --------- Co-authored-by: Claude <noreply@anthropic.com>

Refresh dynamic prices on market refresh #366

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions