Adminhtml: Filter issues with grids using `GET` in combination with `Reset Filter` button

[tmewes]

Description

There are some issues with adminhtml grids using GET ($this->setUseAjax(false); or the line is missing entirely) instead of POST ($this->setUseAjax(true);). The Payment Restrictions grid is a good example.

Steps to reproduce

• Open Sales > Payment Restrictions in adminhtml
• Ensure you have at least one payment restriction (add one if needed)
• Check the url in the grid: Should be something like /admin/payment_restriction/index/key/123123123123123123/
• Filter the column name for the value test
• Check the url again: Should be something like admin/payment_restriction/index/key/123123123123123123/page/1/filter/bmFtZT10ZXN0JmNyZWF0ZWRfYXQlNUJsb2NhbGUlNUQ9ZGVfREU%3D/internal_restriction//form_key/hkc5ekHhVgwKdY6K/ and notice the // (empty param/value) in the url
• Click on Reset Filter
• Check the url again: Should be something like admin/payment_restriction/index/key/123123123123123123/page/1/filter//internal_restriction/form_key/form_key/hkc5ekHhVgwKdY6K/
• In one line of the grid, click on a massaction checkbox
• Select Change status and Status Disabled in the massaction select elements
• Click on Submit
• You will be redirected to the dashboard page and get the following error message:

Currently, using POST isn't mandatory so we could either fix this issue for grids using GET or $this->setUseAjax(true); should globally be the only supported way for grids.

Related Code

• lib/Maho/Routing/ControllerDispatcher.php starting at line 105

• public/js/mage/adminhtml/grid.js

[fballiano]

hey @tmewes! I can't reproduce the bug on the current main branch :-( maybe it was already solved?

[tmewes]

Hey @fballiano! I could reproduce the issue yesterday in all my Maho instances including my local 'stock' one that I use to create PRs. I updated the main branch now and can still reproduce it.

I made a short video:
https://github.com/user-attachments/assets/2b847bba-9e2e-4ac8-92a1-3dfdaac5f6d8

[fballiano]

@tmewes I'll recheck cause it's worth fixing, but in the meanwhile I've merged #1024 which enables ajax on many grids (we still discover half baked features after 15 years...)