Skip to content

Commit 3943d30

Browse files
committed
setup firebase correctly
1 parent ddf8d70 commit 3943d30

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

.github/workflows/deploy-basic-example.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ name: Deploy basic example
33
# Deploys examples/basic to Firebase Hosting.
44
#
55
# Required repository secrets:
6-
# FIREBASE_SERVICE_ACCOUNT - JSON key of a service account with the
7-
# "Firebase Hosting Admin" role on the project
8-
# in examples/basic/.firebaserc
6+
# FIREBASE_SERVICE_ACCOUNT - JSON key of a service account for the
7+
# `mapconductor` Firebase project with the
8+
# "Firebase Hosting Admin" role
99
# VITE_GOOGLE_MAPS_API_KEY - Google Maps JavaScript API key
1010
# VITE_ARCGIS_API_KEY - ArcGIS Location Platform API key
1111
# VITE_MAPBOX_ACCESS_TOKEN - Mapbox access token
@@ -75,7 +75,7 @@ jobs:
7575
- name: Deploy to Firebase Hosting
7676
uses: FirebaseExtended/action-hosting-deploy@v0
7777
with:
78-
repoToken: ${{ secrets.GITHUB_TOKEN }}
7978
firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT }}
79+
projectId: mapconductor
8080
channelId: live
8181
entryPoint: examples/basic

examples/basic/.firebaserc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
{
22
"projects": {
3-
"default": "mapconductor-react"
4-
},
5-
"targets": {},
6-
"etags": {}
3+
"default": "mapconductor"
4+
}
75
}

0 commit comments

Comments
 (0)