Skip to content

Add ability to add blocker to task through GraphQL#3

Open
MaratKarimov21 wants to merge 11 commits into
masterfrom
ability-to-add-blocker-to-task
Open

Add ability to add blocker to task through GraphQL#3
MaratKarimov21 wants to merge 11 commits into
masterfrom
ability-to-add-blocker-to-task

Conversation

@MaratKarimov21

@MaratKarimov21 MaratKarimov21 commented Dec 11, 2021

Copy link
Copy Markdown
Owner

Summary

ability to add blocker to task

How it works

Screenshot 2021-12-22 at 18 11 22

Test plan

List of steps to manually test introduced functionality:

  • Open GraphiQL App
  • Make request using schema:
  query {
    me: {
      id
      name
    }
  }
  • ...

Review notes

While reviewing pull-request (especially when it's your pull-request),
please make sure that:

  • you understand what problem is solved by PR and how is it solved
  • new tests are in place, no redundant tests
  • DB schema changes reflect new migrations
  • newly introduced DB fields have indexes and constraints
  • there are no missed files (migrations, view templates)
  • required ENV variables added and described in .env.example and added to Heroku
  • associated Heroku review app works correctly with introduced changes

Deploy notes

Notes regarding deployment the contained body of work.
These should note any db migrations, ENV variables, services, scripts, etc.

References

Maratkarimov21 added 2 commits December 11, 2021 12:34
Comment thread app/graphql/types/input_fields/add_blocker_input.rb Outdated
Comment thread app/graphql/types/tasks_relation_type.rb Outdated
Comment thread app/graphql/types/tasks_relation_type.rb Outdated
MaratKarimov21 and others added 3 commits December 20, 2021 14:30
Co-authored-by: Sergey Antonov <sergey.antonov@flatstack.com>
Co-authored-by: Sergey Antonov <sergey.antonov@flatstack.com>
Co-authored-by: Sergey Antonov <sergey.antonov@flatstack.com>
module InputFields
class AddBlockerInput < Types::BaseInputObject
argument :blocker_id, Integer, required: true
argument :blocked_id, ID, required: true

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
argument :blocked_id, ID, required: true
argument :blocked_id, Integer, required: true

@MaratKarimov21 MaratKarimov21 self-assigned this Jan 7, 2022
Maratkarimov21 added 2 commits January 8, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants