fixes commands initialization

Author: visschersm

private/Get-Commands.ps1

@@ -1,36 +1,35 @@
 . $PSScriptRoot\..\classes\Command.ps1
 
-$script:CachedCommands = $null
-
 function Get-Commands {
-    if ($null -eq $script:CachedCommands) {
-        $script:CachedCommands = @(
-            [Command]::new("cd", "Set-Alias-Location")
-            [Command]::new("rider", "Open-Command rider" )
-            [Command]::new("vs", "Open-Command visualstudio" )
-            [Command]::new("visualstudio", "Open-Command visualstudio" )
-            [Command]::new("intellij", "Open-Command intellij")
-            [Command]::new("code", "Open-Command code")
-            [Command]::new("ws", "Open-Command webstorm")
-            [Command]::new("webstorm", "Open-Command webstorm")
-            [Command]::new("explorer", "Open-Command explorer")
-            [Command]::new("sourcefolder", "Set-Source-Folder")
-            [Command]::new("help", 'Write-Host $(Get-DynamicHelp $commandNames)' )
-            [Command]::new("alias", @(
-                    [Command]::new("add", "Add-Alias" ), 
-                    [Command]::new("remove", "Remove-Alias" )
-                    [Command]::new("list", { Write-Host ($script:ALIASES | Format-Table | Out-String) })
-                )
+    if ($null -ne $script:COMMANDS) {
+        return $script:COMMANDS
+    }
+    $script:COMMANDS = @(
+        [Command]::new("cd", "Set-Alias-Location")
+        [Command]::new("rider", "Open-Command rider" )
+        [Command]::new("vs", "Open-Command visualstudio" )
+        [Command]::new("visualstudio", "Open-Command visualstudio" )
+        [Command]::new("intellij", "Open-Command intellij")
+        [Command]::new("code", "Open-Command code")
+        [Command]::new("ws", "Open-Command webstorm")
+        [Command]::new("webstorm", "Open-Command webstorm")
+        [Command]::new("explorer", "Open-Command explorer")
+        [Command]::new("sourcefolder", "Set-Source-Folder")
+        [Command]::new("help", 'Write-Host $(Get-DynamicHelp $commandNames)' )
+        [Command]::new("alias", @(
+                [Command]::new("add", "Add-Alias" ), 
+                [Command]::new("remove", "Remove-Alias" )
+                [Command]::new("list", { Write-Host ($script:ALIASES | Format-Table | Out-String) })
             )
-            [Command]::new("todo", @(
-                    [Command]::new("add", "Add-Todo")
-                    [Command]::new("remove", { Write-Host "TODO: remove item from todolist: qp todo remove x" })
-                    [Command]::new("list", { Write-Host "TODO: Output todo list" })
-                )
+        )
+        [Command]::new("todo", @(
+                [Command]::new("add", "Add-Todo")
+                [Command]::new("remove", { Write-Host "TODO: remove item from todolist: qp todo remove x" })
+                [Command]::new("list", { Write-Host "TODO: Output todo list" })
             )
-            [Command]::new("version", { Write-Host (Get-MyModuleVersion) } )
-            [Command]::new("update", { Update-QuickPath -FromGallery })
         )
-    }
-    return $script:CachedCommands
+        [Command]::new("version", { Write-Host (Get-MyModuleVersion) } )
+        [Command]::new("update", { Update-QuickPath -FromGallery })
+    )
+    return $script:COMMANDS
 }

private/Initialize-QuickPath.ps1

@@ -2,13 +2,13 @@
 . $PSScriptRoot\..\private\Get-Commands.ps1
 
 function Initialize-QuickPath {
+    [CmdletBinding()]
+    param()
+    Write-Verbose "Initializing QuickPath..."
     $aliasFilePath = Get-AliasFilePath
     $aliasDirectory = Split-Path $aliasFilePath -Parent
 
-    if (Test-Path $aliasFilePath) {
-        return
-    }
-    
+    # Ensure directory and file exist, but do not return early; we still need to load aliases and commands
     if (-not (Test-Path $aliasDirectory)) {
         New-Item -Path $aliasDirectory -ItemType Directory -Force | Out-Null
     }
@@ -20,4 +20,7 @@ function Initialize-QuickPath {
     $script:JSON_FILE_PATH = $aliasFilePath
     $script:ALIASES = Import-Aliases $aliasFilePath
     $script:COMMANDS = Get-Commands
+
+    Write-Verbose "QuickPath initialized. JSON file: $aliasFilePath"
+    Write-Verbose "Loaded $($script:ALIASES.Count) aliases and $($script:COMMANDS.Count) commands"
 }

quickpath.psm1

@@ -43,35 +43,43 @@ $commandText
 }
 
 function qp {
+    [CmdletBinding()]
+    param(
+        [Parameter(Position = 0)]
+        [string]$Command,
+        
+        [Parameter(Position = 1, ValueFromRemainingArguments = $true)]
+        [string[]]$Arguments
+    )
+    
     try {
         Initialize-QuickPath
 
-        $firstArgument = $args[0]
-        $remainingArguments = $args[1..($args.length - 1)]
+        Write-Verbose "qp: commands available: $($script:COMMANDS.Count)"
 
-        $script:COMMANDS | ForEach-Object { $_.Name } | Sort-Object
+        $commandNames = ($script:COMMANDS | ForEach-Object Name | Sort-Object)
         $helpText = Get-DynamicHelp $commandNames
 
-        $alias = Get-Alias $firstArgument
-        $path = $alias.WindowsPath ?? $firstArgument
+        $alias = Get-Alias @($Command)
+        $path = if ($alias) { $alias.WindowsPath } else { $Command }
 
         if (Test-Path -Path $path) {
             Set-Location $path
             return
         }
 
-        $command = $script:COMMANDS | Where-Object { $_.Name -eq $firstArgument }
-        if ($null -eq $command) {
+        $commandObj = $script:COMMANDS | Where-Object { $_.Name -eq $Command }
+        if ($null -eq $commandObj) {
             Write-Host $helpText
             return
         }
 
-        if ($remainingArguments.length -eq 0) {
-            $command.InvokeFunction()
+        if (-not $Arguments -or $Arguments.length -eq 0) {
+            $commandObj.InvokeFunction()
             return;
         }
 
-        $command.InvokeFunction($remainingArguments)
+        $commandObj.InvokeFunction($Arguments)
     }
     catch {
         Write-Error "Error: $($_.Exception.Message)"