From 59ccbbddd936beb12a47080248b4a9523cceddba Mon Sep 17 00:00:00 2001 From: David Chen Date: Fri, 12 Apr 2019 22:50:47 -0700 Subject: [PATCH 1/2] Update App.jsx --- imports/ui/App.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/imports/ui/App.jsx b/imports/ui/App.jsx index 42bfac4..7227eaa 100644 --- a/imports/ui/App.jsx +++ b/imports/ui/App.jsx @@ -38,6 +38,7 @@ class App extends Component { + {/* You can Do something : */} {this.props.myData.length === 0 ? :
{this.props.myData[0].ingame ? : }
From 65e1dadecab5225bf2b982ace7bbfc12443d556f Mon Sep 17 00:00:00 2001 From: David Chen Date: Sat, 13 Apr 2019 10:58:32 -0700 Subject: [PATCH 2/2] Code Review by David --- imports/ui/About.jsx | 1 + imports/ui/App.jsx | 1 + imports/ui/HomePage.jsx | 2 +- imports/ui/MyGame.jsx | 3 ++- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/imports/ui/About.jsx b/imports/ui/About.jsx index 0208736..28da0d1 100644 --- a/imports/ui/About.jsx +++ b/imports/ui/About.jsx @@ -13,6 +13,7 @@ class About extends Component { About + {/* should escape quote here */}
Dixit is a card game using a deck of cards illustrated with dreamlike images, players select cards that match a title suggestsed by the "storyteller", and attempt to vote which card the "storyteller" selected...
diff --git a/imports/ui/App.jsx b/imports/ui/App.jsx index 7227eaa..31bf313 100644 --- a/imports/ui/App.jsx +++ b/imports/ui/App.jsx @@ -35,6 +35,7 @@ class App extends Component {
+ {/* How to get to this page */} diff --git a/imports/ui/HomePage.jsx b/imports/ui/HomePage.jsx index 2b4e4b0..a4d26d3 100644 --- a/imports/ui/HomePage.jsx +++ b/imports/ui/HomePage.jsx @@ -4,7 +4,7 @@ class HomePage extends Component { render() { return (
- + {/* Here you better have something in the landing page */}
); } diff --git a/imports/ui/MyGame.jsx b/imports/ui/MyGame.jsx index a68281a..a105edc 100644 --- a/imports/ui/MyGame.jsx +++ b/imports/ui/MyGame.jsx @@ -475,6 +475,7 @@ class MyGame extends Component {
:
+ {/* TargetCard might be null */} {this.state.stage === 2 && this.state.isHost?

@@ -660,7 +661,7 @@ MyGame.propTypes = { cards: PropTypes.arrayOf(PropTypes.object).isRequired, ready: PropTypes.bool.isRequired }; - +/* Is it better to pass myGame from App into MyGame? */ export default withTracker(() => { const handle = Meteor.subscribe("myGame"); const handle2 = Meteor.subscribe("gameData");