Skip to content

scripts/deploy.mjs has zero automated test coverage #127

Description

@chonilius

Unlike the Rust contracts (63 tests across the three contract crates), scripts/deploy.mjs — the script the README documents as the actual mechanism used to deploy all three currently-live testnet contracts — has no automated tests at all. Its submitAndWait polling loop and the multi-step upload -> create-contract -> initialize flow are exactly the kind of logic that's easy to silently break with a @stellar/stellar-sdk version bump (the package.json dependency is pinned to ^16.0.1, a range that allows minor/patch updates) with nothing catching a regression before the next real deployment attempt. At minimum, unit-testable pieces (argument parsing, the wasm-path resolution) could be covered without needing a live network.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programdocumentationImprovements or additions to documentationhelp wantedExtra attention is neededtestingTesting/QA infrastructurevery hardVery difficult task, expert-level effort required

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions