Makefile's stellar contract optimize step silently swallows real failures via || true

[chonilius]

In the build target:

@command -v stellar >/dev/null 2>&1 && \
    for c in $(CONTRACTS); do \
        stellar contract optimize --wasm $(WASM_DIR)/$$(echo $$c | tr - _).wasm || true; \
    done || echo "stellar-cli not found; skipping wasm optimize step (optional)"

the || true after stellar contract optimize means that if the optimize step fails for a real reason (a corrupted/malformed .wasm file, a stellar-cli bug, an incompatible CLI version), make build reports success anyway with an un-optimized (or worse, partially-written) wasm artifact and no visible warning — the exact same silence as the deliberate "cli not found" case, which is genuinely optional and fine to swallow. A real optimize failure deserves to fail the build (or at least print a clear warning distinct from the "not installed" message), not disappear identically to the intentionally-skippable case.

[kaizercodes]

@kaizercodes has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi, i would love to fix this, please assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @kaizercodes to this issue.

[p4uld4vid016-code]

@p4uld4vid016-code has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer, i would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @p4uld4vid016-code to this issue.

[gerani1]

@gerani1 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

i would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @gerani1 to this issue.

[victor-134]

@victor-134 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi, I can implement this Asap Kindly assign to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @victor-134 to this issue.

[drips-wave]

Congratulations, @gerani1! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @gerani1: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊