fix(wallet-assets): show actual IPFS NFT image instead of hardcoded CID#240
Merged
Conversation
The IPFS branch of the asset card was passing a single hardcoded ipfs:// literal to <IPFSImage>, so every IPFS-based NFT in the wallet rendered the same placeholder image instead of its own metadata.image. The non-IPFS sibling already uses imageSrc / name / 60x60 correctly; this brings the IPFS branch in line. Also fixes: - alt text now uses the asset name (was "IPFS Image" — bad a11y) - width/height set to 60 to match the parent 60x60 div (was 300, was being clipped by overflow-hidden + wasting bandwidth) Single occurrence in the codebase. Introduced 2025-03-27.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-visible bug: every IPFS-based NFT in the wallet asset list rendered the same hardcoded placeholder image instead of its own metadata. The IPFS branch of the asset card was hardcoded to
ipfs://QmSNkaU4DW3asABKyUfSx3ykFAtV5PuXLsXu63nMUo8HGvand ignoredimageSrc(which holds the asset's actualmetadata.image).The non-IPFS sibling already uses
imageSrc/name/60×60correctly — this brings the IPFS branch in line.Severity: HIGH (user-visible, all IPFS NFTs affected)
Introduced: 2025-03-27 (single occurrence in the codebase)
Changes
src={"ipfs://Qm..."}→src={imageSrc}— show the actual asset's IPFS URLalt="IPFS Image"→alt={name}— a11y, screen readers now announce the NFT namewidth={300} height={300}→width={60} height={60}— matches parent 60×60 div (was being clipped byoverflow-hiddenand wasted bandwidth)Test plan
🤖 Generated with Claude Code