From 58c365ea46e53807a8be342aba9e4b419d963e06 Mon Sep 17 00:00:00 2001
From: mengz <2567587994@qq.com>
Date: Tue, 9 Jun 2026 11:01:41 +0800
Subject: [PATCH] Add counter config validation helpers

---
 mx_exporter/config_validation.py | 47 ++++++++++++++++++++++++++++++++
 tests/test_config_validation.py  | 20 ++++++++++++++
 2 files changed, 67 insertions(+)
 create mode 100644 mx_exporter/config_validation.py
 create mode 100644 tests/test_config_validation.py

diff --git a/mx_exporter/config_validation.py b/mx_exporter/config_validation.py
new file mode 100644
index 0000000..b6d5795
--- /dev/null
+++ b/mx_exporter/config_validation.py
@@ -0,0 +1,47 @@
+"""Validation helpers for mx-exporter counter CSV files."""
+
+import csv
+
+
+SUPPORTED_METRIC_TYPES = {"Gauge", "Counter", "Summary", "Histogram", "Info"}
+
+
+def validate_counter_rows(rows, supported_metrics=None):
+    """Validate parsed counter rows.
+
+    Returns a list of human-readable validation errors. Comment and empty rows
+    are ignored so the function can be used directly with default-counters.csv.
+    """
+
+    supported = set(supported_metrics or [])
+    errors = []
+    seen_names = set()
+
+    for line_no, row in enumerate(rows, start=1):
+        if not row or not row[0] or row[0].startswith("#"):
+            continue
+        if len(row) < 4:
+            errors.append("line %d: expected at least 4 columns" % line_no)
+            continue
+
+        metric_id, metric_type, metric_name, description = [item.strip() for item in row[:4]]
+        if not metric_id:
+            errors.append("line %d: metric id is empty" % line_no)
+        if supported and metric_id not in supported:
+            errors.append("line %d: unsupported metric id %s" % (line_no, metric_id))
+        if metric_type not in SUPPORTED_METRIC_TYPES:
+            errors.append("line %d: unsupported metric type %s" % (line_no, metric_type))
+        if not metric_name.startswith("mx_"):
+            errors.append("line %d: metric name should start with mx_" % line_no)
+        if metric_name in seen_names:
+            errors.append("line %d: duplicated metric name %s" % (line_no, metric_name))
+        seen_names.add(metric_name)
+        if not description:
+            errors.append("line %d: metric description is empty" % line_no)
+
+    return errors
+
+
+def validate_counter_file(path, supported_metrics=None):
+    with open(path, newline="") as handle:
+        return validate_counter_rows(csv.reader(handle), supported_metrics)
diff --git a/tests/test_config_validation.py b/tests/test_config_validation.py
new file mode 100644
index 0000000..c0d29e3
--- /dev/null
+++ b/tests/test_config_validation.py
@@ -0,0 +1,20 @@
+from mx_exporter.config_validation import validate_counter_rows
+
+
+def test_validate_counter_rows_accepts_valid_metric():
+    rows = [["gpu_usage", "Gauge", "mx_gpu_usage", "GPU usage", "deviceId"]]
+
+    assert validate_counter_rows(rows, supported_metrics=["gpu_usage"]) == []
+
+
+def test_validate_counter_rows_reports_common_errors():
+    rows = [
+        ["bad", "BadType", "gpu_usage", ""],
+        ["bad2", "Gauge", "gpu_usage", "duplicate name"],
+    ]
+
+    errors = validate_counter_rows(rows, supported_metrics=["bad", "bad2"])
+    assert any("unsupported metric type" in error for error in errors)
+    assert any("should start with mx_" in error for error in errors)
+    assert any("description is empty" in error for error in errors)
+    assert any("duplicated metric name" in error for error in errors)