From 729b5c731ac2eecec7115e1e647fa9b6766a168a Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Mon, 10 Nov 2025 18:12:37 +0000
Subject: [PATCH 1/2] Initial plan


From 98dd7796ca75f182c09676d68b8b33f9f812736a Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Mon, 10 Nov 2025 18:17:17 +0000
Subject: [PATCH 2/2] Fix MFC/ATL installation and address reviewer comments

Co-authored-by: Mika3578 <58137747+Mika3578@users.noreply.github.com>
---
 .github/workflows/build.yml         | 10 ++++++----
 .github/workflows/code-quality.yml  |  4 ++--
 .github/workflows/security-scan.yml |  2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 597ab1d6..761af0bc 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -36,14 +36,16 @@ jobs:
     - name: Install Visual Studio MFC/ATL Components
       shell: pwsh
       run: |
-        # Visual Studio already includes MFC/ATL in windows-latest runner
+        # Install MFC and ATL components required for building eMule
+        Write-Host "Installing Visual Studio MFC and ATL components..."
+        choco install visualstudio2022-workload-vctools --package-parameters "--add Microsoft.VisualStudio.Component.VC.ATL --add Microsoft.VisualStudio.Component.VC.ATLMFC" -y
+        
         # Verify installation
         $vsPath = & "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath
         Write-Host "Visual Studio Path: $vsPath"
-        Write-Host "Checking MFC/ATL availability..."
         if (Test-Path "$vsPath\VC\Tools\MSVC") {
           $mfcPath = Get-ChildItem "$vsPath\VC\Tools\MSVC" -Directory | Select-Object -Last 1
-          Write-Host "MFC/ATL Path: $mfcPath"
+          Write-Host "MFC/ATL installed at: $mfcPath"
         }
     
     - name: Setup Visual Studio Developer Environment
@@ -79,5 +81,5 @@ jobs:
         echo "Platform: ${{matrix.platform}}" >> $env:GITHUB_STEP_SUMMARY
         if (Test-Path "srchybrid/${{matrix.configuration}}/emule.exe") {
           $fileInfo = Get-Item "srchybrid/${{matrix.configuration}}/emule.exe"
-          echo "Executable Size: $($fileInfo.Length / 1MB) MB" >> $env:GITHUB_STEP_SUMMARY
+          echo "Executable Size: $([math]::Round($fileInfo.Length / 1MB, 2)) MB" >> $env:GITHUB_STEP_SUMMARY
         }
diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
index 637ae530..2fbcd399 100644
--- a/.github/workflows/code-quality.yml
+++ b/.github/workflows/code-quality.yml
@@ -57,7 +57,7 @@ jobs:
         echo "### Code Quality Checks :mag:" >> $env:GITHUB_STEP_SUMMARY
         
         # Check for TODO comments
-        $todos = Select-String -Path srchybrid\*.cpp,srchybrid\*.h -Pattern "TODO|FIXME|HACK" -Recurse -ErrorAction SilentlyContinue
+        $todos = Select-String -Path srchybrid -Include *.cpp,*.h -Pattern "TODO|FIXME|HACK" -Recurse -ErrorAction SilentlyContinue
         if ($todos) {
           $todoCount = ($todos | Measure-Object).Count
           echo "Found $todoCount TODO/FIXME/HACK comments" >> $env:GITHUB_STEP_SUMMARY
@@ -66,7 +66,7 @@ jobs:
         }
         
         # Check for hardcoded paths
-        $hardcodedPaths = Select-String -Path srchybrid\*.cpp -Pattern "C:\\\\|D:\\\\" -Recurse -ErrorAction SilentlyContinue
+        $hardcodedPaths = Select-String -Path srchybrid -Include *.cpp -Pattern "C:\\\\|D:\\\\" -Recurse -ErrorAction SilentlyContinue
         if ($hardcodedPaths) {
           $pathCount = ($hardcodedPaths | Measure-Object).Count
           echo ":warning: Found $pathCount potential hardcoded paths" >> $env:GITHUB_STEP_SUMMARY
diff --git a/.github/workflows/security-scan.yml b/.github/workflows/security-scan.yml
index a625a12a..6c51cb48 100644
--- a/.github/workflows/security-scan.yml
+++ b/.github/workflows/security-scan.yml
@@ -25,7 +25,7 @@ jobs:
         fetch-depth: 0
     
     - name: Run Trivy vulnerability scanner
-      uses: aquasecurity/trivy-action@master
+      uses: aquasecurity/trivy-action@0.28.0
       with:
         scan-type: 'fs'
         scan-ref: '.'