Problem
Typecheck & build fails on main with:
Error: [vitest] No "Networks" export is defined on the "@stellar/stellar-sdk" mock.
Did you forget to return it from "vi.mock"?
Confirmed pre-existing rather than inferred: it fails identically on #137, which adds a single .md file and no code. A markdown-only PR cannot break a typecheck, so the failure is on main.
Why this matters more than one red check
Every open PR in the current batch shows a red Typecheck & build. Contributors can't tell whether they broke something, and reviewers start waving red checks through — which is exactly how a real failure eventually gets merged. A permanently-red required check is worse than no check, because it trains everyone to ignore the signal.
What to do
A vi.mock('@stellar/stellar-sdk', …) factory somewhere in the test suite returns a partial module that omits the Networks export, while some code path under test reads Networks.PUBLIC / Networks.TESTNET.
- Find the offending
vi.mock factory.
- Prefer spreading the real module over hand-listing exports, so future additions don't break it again:
vi.mock('@stellar/stellar-sdk', async (importOriginal) => ({
...(await importOriginal<typeof import('@stellar/stellar-sdk')>()),
// ...only the specific overrides this test needs
}))importOriginal doesn't.
- Confirm
npm test is green on a clean main before closing.
Acceptance criteria
Drips Wave · Complexity: Easy · 100 points
Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk
Problem
Typecheck & buildfails onmainwith:Confirmed pre-existing rather than inferred: it fails identically on #137, which adds a single
.mdfile and no code. A markdown-only PR cannot break a typecheck, so the failure is onmain.Why this matters more than one red check
Every open PR in the current batch shows a red
Typecheck & build. Contributors can't tell whether they broke something, and reviewers start waving red checks through — which is exactly how a real failure eventually gets merged. A permanently-red required check is worse than no check, because it trains everyone to ignore the signal.What to do
A
vi.mock('@stellar/stellar-sdk', …)factory somewhere in the test suite returns a partial module that omits theNetworksexport, while some code path under test readsNetworks.PUBLIC/Networks.TESTNET.vi.mockfactory.importOriginaldoesn't.npm testis green on a cleanmainbefore closing.Acceptance criteria
npm testpasses onmainwith no@stellar/stellar-sdkmock errorsTypecheck & buildis green on a freshly-opened PR@stellar/stellar-sdkuseimportOriginalspreading rather than a hand-listed export setDrips Wave · Complexity: Easy · 100 points
Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk