tests/ is not typechecked — tsconfig include is src/**/* only

[Miracle656]

Problem

tsconfig.json has:

"include": ["src/**/*"]

So tests/ — including the whole tests/integration/ suite — is never typechecked. npm run build and tsc --noEmit can both be clean while integration tests are broken at the type level.

How it surfaced

In #159 (PR #169) the IndexerState primary key changed from a singleton id to network. tsc --noEmit reported 0 errors and all 270 unit tests passed, while six integration suites failed at setup:

PrismaClientValidationError
FAIL tests/integration/api.test.ts
FAIL tests/integration/e2e.test.ts
FAIL tests/integration/migrations.test.ts
FAIL tests/integration/reorg-rollover.test.ts
FAIL tests/integration/reorg.test.ts
FAIL tests/integration/ws.test.ts

Cause: three call sites still used the removed key.

prisma.indexerState.create({ data: { id: 1, lastIndexedLedger: 101 } })
prisma.indexerState.findUnique({ where: { id: 1 } })

A typecheck covering tests/ would have caught all three instantly. Instead they were only found by running the integration job — which needs Postgres and a live API, so it does not run locally for most contributors.

This is a schema-change trap specifically: any future Prisma model change has the same blind spot.

Why the one-line fix does not work

Adding tests/**/* to include fails, because compilerOptions.rootDir is "src":

error TS6059: File 'tests/integration/api.test.ts' is not under rootDir 'src'.

rootDir controls the dist/ layout, so it cannot simply be widened without changing build output.

Suggested approach

Add a separate typecheck-only config that does not participate in the build:

// tsconfig.test.json
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "rootDir": ".",
    "noEmit": true
  },
  "include": ["src/**/*", "tests/**/*"]
}

then wire it into CI, e.g. "typecheck": "tsc --noEmit -p tsconfig.test.json", run alongside the existing build.

Expect some pre-existing errors in tests/ on the first run — those should be fixed (or narrowly suppressed with a comment) as part of this, otherwise the new check lands red and gets ignored.

Acceptance criteria

• tests/**/* is typechecked by some config
• The build output in dist/ is unchanged (no test files emitted)
• CI runs the test typecheck and it is green
• Reverting the { id: 1 } → { network: 'testnet' } fix in tests/integration/setup.ts makes the new check fail (confirms it actually catches this class)

Drips Wave · Complexity: Easy · 100 points

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

[GiftedGiftB]

@GiftedGiftB has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I can get this work done in less than 30 minutes.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @GiftedGiftB to this issue.

[piusandre999-create]

@piusandre999-create has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer, I would like to get assigned to this.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @piusandre999-create to this issue.

[nobodieair]

@nobodieair has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I can fix this, assign me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @nobodieair to this issue.

[lamideseun57-netizen]

@lamideseun57-netizen has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello 👋 maintainer of drip wave, I checked on this issue, seeing that I can easily fix it am confident in working through it till 31st August. Please assign to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @lamideseun57-netizen to this issue.